From: Jakub Kicinski <kuba@kernel.org>
To: <Arun.Ramadoss@microchip.com>
Cc: <andrew@lunn.ch>, <olteanv@gmail.com>, <davem@davemloft.net>,
<Woojung.Huh@microchip.com>, <pabeni@redhat.com>,
<o.rempel@pengutronix.de>, <edumazet@google.com>,
<f.fainelli@gmail.com>, <kernel@pengutronix.de>, <san@skov.dk>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH net-next v1 4/8] net: dsa: microchip: ksz8: Refactor ksz8_r_dyn_mac_table() for readability
Date: Tue, 2 Apr 2024 10:07:26 -0700 [thread overview]
Message-ID: <20240402100726.0516e762@kernel.org> (raw)
In-Reply-To: <e559c5c81e90039f17b555b66c5b3837d410c489.camel@microchip.com>
On Tue, 2 Apr 2024 15:44:30 +0000 Arun.Ramadoss@microchip.com wrote:
> > int rc;
>
> If rc is initialized with 0, we don't need to assign rc = 0 in the
> success path.
Not so sure -- it's easier for the compiler to catch uninitialized
variables than "accidentally stale" values.
next prev parent reply other threads:[~2024-04-02 17:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 13:13 [PATCH net-next v1 0/8] net: dsa: microchip: ksz8: refactor FDB dump path Oleksij Rempel
2024-04-02 13:13 ` [PATCH net-next v1 1/8] net: dsa: microchip: Remove unused FDB timestamp support in ksz8_r_dyn_mac_table() Oleksij Rempel
2024-04-02 15:28 ` Arun.Ramadoss
2024-04-02 13:13 ` [PATCH net-next v1 2/8] net: dsa: microchip: Make ksz8_r_dyn_mac_table() static Oleksij Rempel
2024-04-02 15:29 ` Arun.Ramadoss
2024-04-02 13:13 ` [PATCH net-next v1 3/8] net: dsa: microchip: ksz8: Refactor ksz8_fdb_dump() Oleksij Rempel
2024-04-02 15:37 ` Arun.Ramadoss
2024-04-02 13:13 ` [PATCH net-next v1 4/8] net: dsa: microchip: ksz8: Refactor ksz8_r_dyn_mac_table() for readability Oleksij Rempel
2024-04-02 15:44 ` Arun.Ramadoss
2024-04-02 17:07 ` Jakub Kicinski [this message]
2024-04-02 13:13 ` [PATCH net-next v1 5/8] net: dsa: microchip: ksz8: Unify variable naming in ksz8_r_dyn_mac_table() Oleksij Rempel
2024-04-02 15:45 ` Arun.Ramadoss
2024-04-02 13:13 ` [PATCH net-next v1 6/8] net: dsa: microchip: ksz8_r_dyn_mac_table(): ksz: do not return EAGAIN on timeout Oleksij Rempel
2024-04-03 8:21 ` Arun.Ramadoss
2024-04-02 13:13 ` [PATCH net-next v1 7/8] net: dsa: microchip: ksz8_r_dyn_mac_table(): return read/write error if we got any Oleksij Rempel
2024-04-02 15:59 ` Arun.Ramadoss
2024-04-02 13:13 ` [PATCH net-next v1 8/8] net: dsa: microchip: ksz8_r_dyn_mac_table(): use entries variable to signal 0 entries Oleksij Rempel
2024-04-03 8:18 ` Arun.Ramadoss
2024-04-03 11:21 ` [PATCH net-next v1 0/8] net: dsa: microchip: ksz8: refactor FDB dump path Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240402100726.0516e762@kernel.org \
--to=kuba@kernel.org \
--cc=Arun.Ramadoss@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=Woojung.Huh@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=san@skov.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).