From: Vladimir Oltean <olteanv@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Russell King <linux@armlinux.org.uk>,
Gregory Clement <gregory.clement@bootlin.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v3 5/7] net: dsa: Add helpers to convert netdev to ds or port index
Date: Tue, 2 Apr 2024 13:56:52 +0300 [thread overview]
Message-ID: <20240402105652.mrweu2rnend3n3tf@skbuf> (raw)
In-Reply-To: <20240401-v6-8-0-net-next-mv88e6xxx-leds-v4-v3-5-221b3fa55f78@lunn.ch>
On Mon, Apr 01, 2024 at 08:35:50AM -0500, Andrew Lunn wrote:
> The LED helpers make use of a struct netdev. Add helpers a DSA driver
> can use to convert a netdev to a struct dsa_switch and the port index.
>
> To do this, dsa_user_to_port() has to be made available out side of
> net/dev, to convert the inline function in net/dsa/user.h into a
> normal function, and export it.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---
I think the API we have today is sufficient: we have dsa_port_to_netdev(),
introduced at Vivien's request rather than exporting dsa_user_to_port().
Also, I believe that having a single API function which returns a single
struct dsa_port *, from which we force the caller to get the dp->ds and
dp->index, is better (cheaper) than requiring 2 API functions, one for
getting the ds and the other for the index.
next prev parent reply other threads:[~2024-04-02 10:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-01 13:35 [PATCH net-next v3 0/7] net: Add generic support for netdev LEDs Andrew Lunn
2024-04-01 13:35 ` [PATCH net-next v3 1/7] dsa: move call to driver port_setup after creation of netdev Andrew Lunn
2024-04-01 15:53 ` Vladimir Oltean
2024-04-01 13:35 ` [PATCH net-next v3 2/7] net: Add helpers for netdev LEDs Andrew Lunn
2024-04-02 9:53 ` Vladimir Oltean
2024-04-03 23:43 ` Andrew Lunn
2024-04-01 13:35 ` [PATCH net-next v3 3/7] net: dsa: mv88e6xxx: Add helpers for 6352 LED blink and brightness Andrew Lunn
2024-04-01 13:35 ` [PATCH net-next v3 4/7] net: dsa: mv88e6xxx: Tie the low level LED functions to device ops Andrew Lunn
2024-04-01 13:35 ` [PATCH net-next v3 5/7] net: dsa: Add helpers to convert netdev to ds or port index Andrew Lunn
2024-04-02 10:56 ` Vladimir Oltean [this message]
2024-04-02 13:31 ` Russell King (Oracle)
2024-04-02 20:51 ` Vladimir Oltean
2024-04-01 13:35 ` [PATCH net-next v3 6/7] dsa: mv88e6xxx: Create port/netdev LEDs Andrew Lunn
2024-04-02 11:03 ` Vladimir Oltean
2024-04-01 13:35 ` [PATCH net-next v3 7/7] arm: boot: dts: mvebu: linksys-mamba: Add Ethernet LEDs Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240402105652.mrweu2rnend3n3tf@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=gregory.clement@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox