From: Jakub Kicinski <kuba@kernel.org>
To: Catalin Popescu <catalin.popescu@leica-geosystems.com>
Cc: andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
m.felsch@pengutronix.de,
bsp-development.geo@leica-geosystems.com
Subject: Re: [PATCH net-next v2] net: phy: dp8382x: keep WOL settings across suspends
Date: Tue, 2 Apr 2024 17:45:36 -0700 [thread overview]
Message-ID: <20240402174536.75cbe074@kernel.org> (raw)
In-Reply-To: <20240328133358.30544-1-catalin.popescu@leica-geosystems.com>
On Thu, 28 Mar 2024 14:33:58 +0100 Catalin Popescu wrote:
> -static int dp83822_set_wol(struct phy_device *phydev,
> - struct ethtool_wolinfo *wol)
> +static int _dp83822_set_wol(struct phy_device *phydev,
> + struct ethtool_wolinfo *wol)
Why the underscore, you can all this any number of things maybe
dp83822_config_wol() or dp83822_apply_wol()?
next prev parent reply other threads:[~2024-04-03 0:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 13:33 [PATCH net-next v2] net: phy: dp8382x: keep WOL settings across suspends Catalin Popescu
2024-04-03 0:45 ` Jakub Kicinski [this message]
2024-04-03 7:15 ` POPESCU Catalin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240402174536.75cbe074@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=bsp-development.geo@leica-geosystems.com \
--cc=catalin.popescu@leica-geosystems.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=m.felsch@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).