From: Jakub Kicinski <kuba@kernel.org>
To: Jose Ignacio Tornos Martinez <jtornosm@redhat.com>
Cc: horms@kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, linux-usb@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org,
Dave Stevenson <dave.stevenson@raspberrypi.com>
Subject: Re: [PATCH net v3] net: usb: ax88179_178a: avoid the interface always configured as random address
Date: Tue, 2 Apr 2024 18:30:12 -0700 [thread overview]
Message-ID: <20240402183012.119f1511@kernel.org> (raw)
In-Reply-To: <20240401082004.7412-1-jtornosm@redhat.com>
On Mon, 1 Apr 2024 10:19:50 +0200 Jose Ignacio Tornos Martinez wrote:
> if (is_valid_ether_addr(mac)) {
> eth_hw_addr_set(dev->net, mac);
> + dev->net->addr_assign_type = NET_ADDR_PERM;
Are we 100% sure we won't read back the random address we wrote earlier?
Maybe let's put the assignment under if (!is_local_ether_addr(mac)),
just to be on the safe side?
next prev parent reply other threads:[~2024-04-03 1:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-01 8:19 [PATCH net v3] net: usb: ax88179_178a: avoid the interface always configured as random address Jose Ignacio Tornos Martinez
2024-04-02 8:36 ` Simon Horman
2024-04-03 1:30 ` Jakub Kicinski [this message]
2024-04-03 13:16 ` Jose Ignacio Tornos Martinez
2024-04-03 13:21 ` [PATCH net v4] " Jose Ignacio Tornos Martinez
2024-04-04 13:54 ` Simon Horman
2024-04-04 16:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240402183012.119f1511@kernel.org \
--to=kuba@kernel.org \
--cc=dave.stevenson@raspberrypi.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jtornosm@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).