From: Jakub Kicinski <kuba@kernel.org>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Donald Hunter <donald.hunter@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
Jacob Keller <jacob.e.keller@intel.com>,
Stanislav Fomichev <sdf@google.com>
Subject: Re: [PATCHv3 net-next 2/2] ynl: support binary/u32 sub-type for indexed-array
Date: Wed, 3 Apr 2024 17:07:59 -0700 [thread overview]
Message-ID: <20240403170759.5310ca97@kernel.org> (raw)
In-Reply-To: <ZgzMmqWzRvdk4wzP@Laptop-X1>
On Wed, 3 Apr 2024 11:27:22 +0800 Hangbin Liu wrote:
> OK, I can separate the binary and u32 dealing. How about like
>
> diff --git a/tools/net/ynl/lib/ynl.py b/tools/net/ynl/lib/ynl.py
> index e5ad415905c7..be42e4fc1037 100644
> --- a/tools/net/ynl/lib/ynl.py
> +++ b/tools/net/ynl/lib/ynl.py
> @@ -640,6 +640,16 @@ class YnlFamily(SpecFamily):
> if attr_spec["sub-type"] == 'nest':
> subattrs = self._decode(NlAttrs(item.raw), attr_spec['nested-attributes'])
> decoded.append({ item.type: subattrs })
> + elif attr_spec["sub-type"] == 'binary':
> + subattrs = item.as_bin()
> + if attr_spec.display_hint:
> + subattrs = self._formatted_string(subattrs, attr_spec.display_hint)
> + decoded.append(subattrs)
> + elif attr_spec["sub-type"] in NlAttr.type_formats:
> + subattrs = item.as_scalar(attr_spec['sub-type'], attr_spec.byte_order)
> + if attr_spec.display_hint:
> + subattrs = self._formatted_string(subattrs, attr_spec.display_hint)
> + decoded.append(subattrs)
Aha, this look right!
next prev parent reply other threads:[~2024-04-04 0:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-01 3:56 [PATCHv3 net-next 0/2] ynl: rename array-nest to indexed-array Hangbin Liu
2024-04-01 3:56 ` [PATCHv3 net-next 1/2] " Hangbin Liu
2024-04-01 3:56 ` [PATCHv3 net-next 2/2] ynl: support binary/u32 sub-type for indexed-array Hangbin Liu
2024-04-02 4:43 ` Jakub Kicinski
2024-04-03 2:28 ` Hangbin Liu
2024-04-03 2:35 ` Jakub Kicinski
2024-04-03 3:27 ` Hangbin Liu
2024-04-04 0:07 ` Jakub Kicinski [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-04-04 6:31 [PATCHv4 net-next 0/2] ynl: rename array-nest to indexed-array Hangbin Liu
2024-04-04 6:31 ` [PATCHv3 net-next 2/2] ynl: support binary/u32 sub-type for indexed-array Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240403170759.5310ca97@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=jiri@resnulli.us \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).