Re: [PATCH net-next 3/3] net: sparx5: add support for tc flower redirect action

[Horatiu Vultur <horatiu.vultur@microchip.com>]

The 04/03/2024 20:41, Daniel Machon wrote:

Hi Daniel,

  
> +static int sparx5_tc_action_redirect(struct vcap_admin *admin,
> +				     struct vcap_rule *vrule,
> +				     struct flow_cls_offload *fco,
> +				     struct flow_action_entry *act)
> +{
> +	struct vcap_u72_action ports = {0};
> +	int err;

The same comments from previous patch applies also here.

> +
> +	if (admin->vtype != VCAP_TYPE_IS0 && admin->vtype != VCAP_TYPE_IS2) {
> +		NL_SET_ERR_MSG_MOD(fco->common.extack,
> +				   "Redirect action not supported in this VCAP");
> +		return -EOPNOTSUPP;
> +	}
> +
> +	err = vcap_rule_add_action_u32(vrule, VCAP_AF_MASK_MODE,
> +				       SPX5_PMM_REPLACE_ALL);
> +	if (err)
> +		return err;
> +
> +	sparx5_tc_flower_set_port_mask(&ports, act->dev);
> +
> +	err = vcap_rule_add_action_u72(vrule, VCAP_AF_PORT_MASK, &ports);
> +	if (err)
> +		return err;
> +

And here.

> +	return 0;
> +}
 
> -- 
> 2.34.1
> 

-- 
/Horatiu