From: Jakub Kicinski <kuba@kernel.org>
To: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: <andrew@lunn.ch>, <hkallweit1@gmail.com>, <linux@armlinux.org.uk>,
<davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<richardcochran@gmail.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH net-next 2/2] net: phy: micrel: lan8814: Add support for PTP_PF_PEROUT
Date: Thu, 4 Apr 2024 09:41:37 -0700 [thread overview]
Message-ID: <20240404094137.51b1397e@kernel.org> (raw)
In-Reply-To: <20240404080115.450929-3-horatiu.vultur@microchip.com>
On Thu, 4 Apr 2024 10:01:15 +0200 Horatiu Vultur wrote:
> + if (period_nsec < 200) {
> + pr_warn_ratelimited("%s: perout period too small, minimum is 200 nsec\n",
> + phydev_name(phydev));
> + return -EOPNOTSUPP;
> + }
> +
> + if (on_nsec >= period_nsec) {
> + pr_warn_ratelimited("%s: pulse width must be smaller than period\n",
> + phydev_name(phydev));
> + return -EINVAL;
> + }
-ENOUNLOCK brought to you by coccicheck:
drivers/net/phy/micrel.c:3049:2-8: preceding lock on line 3017
--
pw-bot: cr
next prev parent reply other threads:[~2024-04-04 16:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-04 8:01 [PATCH net-next 0/2] net: phy: micrel: lan8814: Enable PTP_PF_PEROUT Horatiu Vultur
2024-04-04 8:01 ` [PATCH net-next 1/2] net: phy: micrel: lan8814: Enable LTC at probe time Horatiu Vultur
2024-04-04 8:01 ` [PATCH net-next 2/2] net: phy: micrel: lan8814: Add support for PTP_PF_PEROUT Horatiu Vultur
2024-04-04 16:41 ` Jakub Kicinski [this message]
2024-04-05 8:35 ` Divya.Koppera
2024-04-05 9:16 ` Horatiu Vultur - M31836
2024-04-04 10:40 ` [PATCH net-next 0/2] net: phy: micrel: lan8814: Enable PTP_PF_PEROUT Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240404094137.51b1397e@kernel.org \
--to=kuba@kernel.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).