From: Jason Xing <kerneljasonxing@gmail.com>
To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, matttbe@kernel.org, martineau@kernel.org,
geliang@kernel.org
Cc: mptcp@lists.linux.dev, netdev@vger.kernel.org,
kerneljasonxing@gmail.com, Jason Xing <kernelxing@tencent.com>
Subject: [PATCH net-next 1/2] mptcp: don't need to check SKB_EXT_MPTCP in mptcp_reset_option()
Date: Fri, 5 Apr 2024 10:39:13 +0800 [thread overview]
Message-ID: <20240405023914.54872-2-kerneljasonxing@gmail.com> (raw)
In-Reply-To: <20240405023914.54872-1-kerneljasonxing@gmail.com>
From: Jason Xing <kernelxing@tencent.com>
Before this, what mptcp_reset_option() checks is totally the same as
mptcp_get_ext() does, so we could skip it.
Signed-off-by: Jason Xing <kernelxing@tencent.com>
---
include/net/mptcp.h | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/include/net/mptcp.h b/include/net/mptcp.h
index fb996124b3d5..42d13ee26619 100644
--- a/include/net/mptcp.h
+++ b/include/net/mptcp.h
@@ -215,10 +215,7 @@ __be32 mptcp_get_reset_option(const struct sk_buff *skb);
static inline __be32 mptcp_reset_option(const struct sk_buff *skb)
{
- if (skb_ext_exist(skb, SKB_EXT_MPTCP))
- return mptcp_get_reset_option(skb);
-
- return htonl(0u);
+ return mptcp_get_reset_option(skb);
}
#else
--
2.37.3
next prev parent reply other threads:[~2024-04-05 2:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-05 2:39 [PATCH net-next 0/2] mptcp: add reset reasons in skb in more cases Jason Xing
2024-04-05 2:39 ` Jason Xing [this message]
2024-04-05 7:47 ` [PATCH net-next 1/2] mptcp: don't need to check SKB_EXT_MPTCP in mptcp_reset_option() Paolo Abeni
2024-04-05 7:58 ` Jason Xing
2024-04-05 8:34 ` Paolo Abeni
2024-04-05 9:11 ` Jason Xing
2024-04-05 2:39 ` [PATCH net-next 2/2] mptcp: add reset reason options in some places Jason Xing
2024-04-05 8:16 ` Paolo Abeni
2024-04-05 9:09 ` Jason Xing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240405023914.54872-2-kerneljasonxing@gmail.com \
--to=kerneljasonxing@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geliang@kernel.org \
--cc=kernelxing@tencent.com \
--cc=kuba@kernel.org \
--cc=martineau@kernel.org \
--cc=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).