From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63AD879F3; Fri, 5 Apr 2024 14:32:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712327568; cv=none; b=js7GfxzPfZMOHB6rDc1rzrxySkJNcz1qZr99gbPYogqhzO5yoiMbIkzAGCzrTd9Hej8bri89+pLFiz1uyCuQgV/Bu2pESrftPfkfRsUTZrLXQOZ+t8T9hWfLRXR9/77v9y6CWWIhjGyldH1Kfpo61FthhyLgLKfjhh68JzfJ4rw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712327568; c=relaxed/simple; bh=+oo3aoyeQYFyc18BS/Ko8Z7rugy4H+kTpGy/XFlZNaw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MtN2oXrM8GFl7o5AfvgJy9vZEgwWGSywmQmnVTRM/6UZOe6YDoE1Orm0gH4aJAwQ11AtdMO+TALE5SXcEAube5S9udZooyxYwizswvM1nKo7MI2byUIzUn+Z7njiElSlODHzG78Elzy0AZ5Pczeoa4eJpHDs3BJ6YOAleL2kHCo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ggW49QXl; arc=none smtp.client-ip=209.85.208.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ggW49QXl" Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-56e2e09fc27so1464662a12.0; Fri, 05 Apr 2024 07:32:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712327565; x=1712932365; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=BS81x8TgiZotkdmg7KJCaBTl5pwcK5PQXZyvnJwjgzU=; b=ggW49QXlevp0AievJMN1YSQ2eBmP8twPi5t7HqxnCoVRNQaOJadgQOsRfxu8/cZHiN Ei+/LALmMcZzZ1BjXELKV8FJFiFqX+oPS5c65IiFeHWGfYpgG0Bdk1u45W1J2IYt4B3o c3LSfZXk/A6hafj0PW7r9ZnWLZjSSOIP4IjQBUBKMbEtWl849hx/xCG3cHe4Dj2BHTkp G39ENaX+b6/ePlSBMFsTucm+u7enrvVU5EEsPHn9iNUN3A0FkbMahtPFJvN3Fzqkww3O EvbmNr9hK1PHJgI1dn0YcFmCJXFnry+ym9AGEu/VghQ/VtIJFJsdLwmRtbOaKBQPs0Yq Pjpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712327565; x=1712932365; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BS81x8TgiZotkdmg7KJCaBTl5pwcK5PQXZyvnJwjgzU=; b=FMZJA4mEDi9wBgQoAlasqCLJ++URUcWX5nDn9FZ0re/gp4+Ry8XqXenmMW/eVDXvOH yHgV7sYPakg3D5VoR9sDbAcuSLu3QD2vn6TlV/oQvz/xgljpzYTdPInGdmOuacYVZZS7 MkBBhd/mTFgeGkkv7IDHTIGRelvTDiqNl4jzaLRTemCeqoBq20d+bOsWgu0TssR7BkPU gksd5ZJcffclKkQBUvv2TZK7Ytl3VKnpRBBItuCASaztzZg3ivDTmxinQSNB8FFZCChr /qG3x5UWx2q3+QLnTFdjI+FCJ5zUGRt65jlKEicNRoD/ad+ddPHUfR8ASdAO9qhd5f5H pryA== X-Forwarded-Encrypted: i=1; AJvYcCXsPC+YufjxWgRPhvfNMT3D1lkMD0M/wmH8q018RneUQgCPPdSxKs9VsNYJYmDqJxq6pQgvIzu/69qcKOHoctpnbnTD9LVTm/T9kcsO X-Gm-Message-State: AOJu0YyG1ro7r4Lhc3++pfjwC0/fKXtCzAy0c/b05Gi7zMwJkZat7aNn itnqhR+Qv8GZYKWm8d86qoNPMNcuZBTuhcXKDesADZOyIsfv451+ X-Google-Smtp-Source: AGHT+IHknrErSLdjdwLAoXYuvvbyExzg4+NqILRcgR1gVkWXerNNZU/EBW3H5xt1vN3N51pBrlnpsQ== X-Received: by 2002:a50:bb29:0:b0:56d:c85a:7893 with SMTP id y38-20020a50bb29000000b0056dc85a7893mr70911ede.8.1712327564348; Fri, 05 Apr 2024 07:32:44 -0700 (PDT) Received: from skbuf ([2a02:2f04:d700:2000::b2c]) by smtp.gmail.com with ESMTPSA id h1-20020a0564020e8100b005682a0e915fsm841041eda.76.2024.04.05.07.32.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 07:32:43 -0700 (PDT) Date: Fri, 5 Apr 2024 17:32:40 +0300 From: Vladimir Oltean To: Pawel Dembicki Cc: netdev@vger.kernel.org, Linus Walleij , Simon Horman , Russell King , Andrew Lunn , Florian Fainelli , Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Claudiu Manoil , Alexandre Belloni , UNGLinuxDriver@microchip.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v8 01/16] net: dsa: vsc73xx: use read_poll_timeout instead delay loop Message-ID: <20240405143240.rwm5klyy7nm7lvdm@skbuf> References: <20240403103734.3033398-1-paweldembicki@gmail.com> <20240403103734.3033398-2-paweldembicki@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240403103734.3033398-2-paweldembicki@gmail.com> On Wed, Apr 03, 2024 at 12:37:17PM +0200, Pawel Dembicki wrote: > Switch the delay loop during the Arbiter empty check from > vsc73xx_adjust_link() to use read_poll_timeout(). Functionally, > one msleep() call is eliminated at the end of the loop in the timeout > case. > > As Russell King suggested: > > "This [change] avoids the issue that on the last iteration, the code reads > the register, tests it, finds the condition that's being waiting for is > false, _then_ waits and end up printing the error message - that last > wait is rather useless, and as the arbiter state isn't checked after > waiting, it could be that we had success during the last wait." > > Suggested-by: Russell King > Reviewed-by: Andrew Lunn > Reviewed-by: Linus Walleij > Reviewed-by: Florian Fainelli > Signed-off-by: Pawel Dembicki > --- Reviewed-by: Vladimir Oltean