From: Jakub Kicinski <kuba@kernel.org>
To: Heng Qi <hengqi@linux.alibaba.com>
Cc: netdev@vger.kernel.org, virtualization@lists.linux.dev,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Jason Wang <jasowang@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Ratheesh Kannoth <rkannoth@marvell.com>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Subject: Re: [PATCH net-next v4 1/4] ethtool: provide customized dim profile management
Date: Mon, 8 Apr 2024 12:09:24 -0700 [thread overview]
Message-ID: <20240408120924.1f01e722@kernel.org> (raw)
In-Reply-To: <1712547870-112976-2-git-send-email-hengqi@linux.alibaba.com>
On Mon, 8 Apr 2024 11:44:27 +0800 Heng Qi wrote:
> --- a/Documentation/netlink/specs/ethtool.yaml
> +++ b/Documentation/netlink/specs/ethtool.yaml
> @@ -408,6 +408,18 @@ attribute-sets:
> -
> name: combined-count
> type: u32
> + -
> + name: profile
> + attributes:
> + -
> + name: usec
> + type: u16
> + -
> + name: pkts
> + type: u16
> + -
> + name: comps
> + type: u16
>
> -
> name: coalesce
> @@ -497,6 +509,23 @@ attribute-sets:
> -
> name: tx-aggr-time-usecs
> type: u32
> + -
> + name: rx-eqe-profs
> + type: nest
> + nested-attributes: profile
> + -
> + name: rx-cqe-profs
> + type: nest
> + nested-attributes: profile
> + -
> + name: tx-eqe-profs
> + type: nest
> + nested-attributes: profile
> + -
> + name: tx-cqe-profs
> + type: nest
> + nested-attributes: profile
Something wrong with the YAML format :(
while parsing a block collection
in "../../../../Documentation/netlink/specs/ethtool.yaml", line 25, column 3
expected <block end>, but found '<block sequence start>'
in "../../../../Documentation/netlink/specs/ethtool.yaml", line 416, column 4
while parsing a block collection
in "../../../../Documentation/netlink/specs/ethtool.yaml", line 25, column 3
expected <block end>, but found '<block sequence start>'
in "../../../../Documentation/netlink/specs/ethtool.yaml", line 416, column 4
does make -C tools/net/ynl work for you?
--
pw-bot: cr
next prev parent reply other threads:[~2024-04-08 19:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 3:44 [PATCH net-next v4 0/4] ethtool: provide the dim profile fine-tuning channel Heng Qi
2024-04-08 3:44 ` [PATCH net-next v4 1/4] ethtool: provide customized dim profile management Heng Qi
2024-04-08 19:09 ` Jakub Kicinski [this message]
2024-04-08 19:13 ` Jakub Kicinski
2024-04-09 8:38 ` Heng Qi
2024-04-08 3:44 ` [PATCH net-next v4 2/4] linux/dim: move profiles from .c to .h file Heng Qi
2024-04-08 3:44 ` [PATCH net-next v4 3/4] virtio-net: refactor dim initialization/destruction Heng Qi
2024-04-08 3:44 ` [PATCH net-next v4 4/4] virtio-net: support dim profile fine-tuning Heng Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240408120924.1f01e722@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hengqi@linux.alibaba.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rkannoth@marvell.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).