From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA9FC54BDA for ; Tue, 9 Apr 2024 02:58:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712631496; cv=none; b=CpYrBtxJIUehvK+NPJUo3GoVesYAG+VyMHJG7hAOVKO35QYxceKZAJWBStrSxk5D8d/VeHLyUY0V/He8MouRtoPf5B0weLQC3/Y17+B54MOhYxu/RvKc9QYXKIVdCzvFMtugPzja/FKcue5VhaWsxWSemOjr0jJWrZ70MAGYJ2o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712631496; c=relaxed/simple; bh=EyG6VlwVh1JdzHgStFWheyZTdryl6aVNweMcKHy64rI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=oSqNlGS6/18wsC8+ORzacbrh5RSlwBRomkMhjErlqwMA+xaT47WZHtYIMpZxpdxr7Tf86ix4LPgjUxYnGdWA8ewQoBtF2BIhNG41NofjouvfzurvKHRsVlsScR3dbVY4WusW3YXVjBirvLrircNEf5JJRG2puTO5EXuFn8i3T3Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Q5jvAn94; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Q5jvAn94" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 20C8EC43390; Tue, 9 Apr 2024 02:58:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712631496; bh=EyG6VlwVh1JdzHgStFWheyZTdryl6aVNweMcKHy64rI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Q5jvAn94deBQudR6ShaTVw92uOkvquvChz+Hx13fGa3HpejC+SSCdcGZq5WCqjA/q SO56JHFAPY3SI2iJsV8vwPrHxMqDXh+mhaeVYl7aVnk5AaojnsXNPzN6ACnz5v26Ck kPKazeW6cCvZ1G58SYB6cNsf4u+3tOArTEhux2n4ryaOCvED34D2t/9szFS3tYhe46 LSXJDN7Js9FXMz5OX6lXJYE2DIynludgbcu60Rbr24HApNmiU15noQI1CWSABKmHjO XxRBSjrL9dRUAlOvtUhxHamAdJk8Wc+1HvniIX40Xmvr9lc6HHGjIc0f8akjqabKcN dtYfJYXBk5mtQ== Date: Mon, 8 Apr 2024 19:58:15 -0700 From: Jakub Kicinski To: Louis Peens Cc: David Miller , Paolo Abeni , Jiri Pirko , Fei Qin , netdev@vger.kernel.org, oss-drivers@corigine.com Subject: Re: [PATCH net-next v4 2/4] nfp: update devlink device info output Message-ID: <20240408195815.5e932da3@kernel.org> In-Reply-To: <20240405081547.20676-3-louis.peens@corigine.com> References: <20240405081547.20676-1-louis.peens@corigine.com> <20240405081547.20676-3-louis.peens@corigine.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 5 Apr 2024 10:15:45 +0200 Louis Peens wrote: > + * - ``board.part_number`` > + - fixed > + - Part number of the board design Sorry, one more nit. Part number is not "of the board design" Part number is a part number, AFAIU it's a customer-facing identifier of a product. Let's drop the design or say "of the board and its components"? Since AFAIU part number may also change if you replace a component even if you don't have to redesign the PCB?