From: Vladimir Oltean <olteanv@gmail.com>
To: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
Cc: Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next 2/3] net: dsa: allow DSA switch drivers to provide their own phylink mac ops
Date: Tue, 9 Apr 2024 15:37:31 +0300 [thread overview]
Message-ID: <20240409123731.t3stvkcnjnr6mswb@skbuf> (raw)
In-Reply-To: <E1rtn25-0065p0-2C@rmk-PC.armlinux.org.uk>
On Mon, Apr 08, 2024 at 12:19:25PM +0100, Russell King (Oracle) wrote:
> +static void dsa_shared_port_link_down(struct dsa_port *dp)
> +{
> + struct dsa_switch *ds = dp->ds;
> +
> + if (ds->phylink_mac_ops) {
> + if (ds->phylink_mac_ops->mac_link_down)
> + ds->phylink_mac_ops->mac_link_down(&dp->pl_config,
> + MLO_AN_FIXED,
> + PHY_INTERFACE_MODE_NA);
> + } else {
> + if (ds->ops->phylink_mac_link_down)
> + ds->ops->phylink_mac_link_down(ds, dp->index,
> + MLO_AN_FIXED, PHY_INTERFACE_MODE_NA);
> + }
> +}
Please roll this other change into the patch when respinning:
else {
if { }
}
becomes
else if {}
Also please align the arguments of the phylink_mac_link_down() call with
the open parenthesis.
next prev parent reply other threads:[~2024-04-09 12:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 11:19 [PATCH net-next 0/3] net: dsa: allow phylink_mac_ops in DSA drivers Russell King (Oracle)
2024-04-08 11:19 ` [PATCH net-next 1/3] net: dsa: introduce dsa_phylink_to_port() Russell King (Oracle)
2024-04-08 23:41 ` Andrew Lunn
2024-04-08 23:50 ` Florian Fainelli
2024-04-08 11:19 ` [PATCH net-next 2/3] net: dsa: allow DSA switch drivers to provide their own phylink mac ops Russell King (Oracle)
2024-04-08 23:45 ` Andrew Lunn
2024-04-08 23:51 ` Florian Fainelli
2024-04-09 3:15 ` kernel test robot
2024-04-09 8:04 ` Russell King (Oracle)
2024-04-09 12:37 ` Vladimir Oltean [this message]
2024-04-09 15:33 ` Vladimir Oltean
2024-04-09 16:29 ` Russell King (Oracle)
2024-04-09 16:52 ` Vladimir Oltean
2024-04-09 18:22 ` Russell King (Oracle)
2024-04-08 11:19 ` [PATCH net-next 3/3] net: dsa: mv88e6xxx: provide own phylink MAC operations Russell King (Oracle)
2024-04-08 23:45 ` Andrew Lunn
2024-04-08 23:51 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240409123731.t3stvkcnjnr6mswb@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox