From: Jakub Kicinski <kuba@kernel.org>
To: Kory Maincent <kory.maincent@bootlin.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Jonathan Corbet <corbet@lwn.net>,
Luis Chamberlain <mcgrof@kernel.org>,
Russ Weight <russ.weight@linux.dev>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Oleksij Rempel <o.rempel@pengutronix.de>,
Mark Brown <broonie@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, devicetree@vger.kernel.org,
Dent Project <dentproject@linuxfoundation.org>,
kernel@pengutronix.de,
Maxime Chevallier <maxime.chevallier@bootlin.com>
Subject: Re: [PATCH net-next v7 13/17] net: pse-pd: Use regulator framework within PSE framework
Date: Tue, 9 Apr 2024 14:16:21 -0700 [thread overview]
Message-ID: <20240409141621.392bd34b@kernel.org> (raw)
In-Reply-To: <20240409-feature_poe-v7-13-11e38efd4dee@bootlin.com>
On Tue, 09 Apr 2024 17:04:03 +0200 Kory Maincent wrote:
> -static inline struct pse_control *of_pse_control_get(struct device_node *node)
> +static inline struct pse_control *of_pse_control_get(struct device *dev,
> + struct device_node *node)
One of the related patches breaks the build:
drivers/net/mdio/fwnode_mdio.c: In function ‘fwnode_find_pse_control’:
drivers/net/mdio/fwnode_mdio.c:32:35: error: passing argument 1 of ‘of_pse_control_get’ from incompatible pointer type [-Werror=incompatible-pointer-types]
32 | psec = of_pse_control_get(np);
| ^~
| |
| struct device_node *
In file included from drivers/net/mdio/fwnode_mdio.c:13:
./include/linux/pse-pd/pse.h:157:69: note: expected ‘struct device *’ but argument is of type ‘struct device_node *’
157 | static inline struct pse_control *of_pse_control_get(struct device *dev,
| ~~~~~~~~~~~~~~~^~~
drivers/net/mdio/fwnode_mdio.c:32:16: error: too few arguments to function ‘of_pse_control_get’
32 | psec = of_pse_control_get(np);
| ^~~~~~~~~~~~~~~~~~
In file included from drivers/net/mdio/fwnode_mdio.c:13:
./include/linux/pse-pd/pse.h:157:35: note: declared here
157 | static inline struct pse_control *of_pse_control_get(struct device *dev,
| ^~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
next prev parent reply other threads:[~2024-04-09 21:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 15:03 [PATCH net-next v7 00/17] net: Add support for Power over Ethernet (PoE) Kory Maincent
2024-04-09 15:03 ` [PATCH net-next v7 01/17] MAINTAINERS: net: Add Oleksij to pse-pd maintainers Kory Maincent
2024-04-09 15:03 ` [PATCH net-next v7 02/17] of: property: Add fw_devlink support for pse parent Kory Maincent
2024-04-09 15:03 ` [PATCH net-next v7 03/17] net: pse-pd: Rectify and adapt the naming of admin_cotrol member of struct pse_control_config Kory Maincent
2024-04-09 15:03 ` [PATCH net-next v7 04/17] ethtool: Expand Ethernet Power Equipment with c33 (PoE) alongside PoDL Kory Maincent
2024-04-09 15:03 ` [PATCH net-next v7 05/17] net: pse-pd: Introduce PSE types enumeration Kory Maincent
2024-04-09 15:03 ` [PATCH net-next v7 06/17] net: ethtool: pse-pd: Expand pse commands with the PSE PoE interface Kory Maincent
2024-04-09 15:03 ` [PATCH net-next v7 07/17] netlink: specs: Modify pse attribute prefix Kory Maincent
2024-04-09 15:03 ` [PATCH net-next v7 08/17] netlink: specs: Expand the pse netlink command with PoE interface Kory Maincent
2024-04-09 15:03 ` [PATCH net-next v7 09/17] MAINTAINERS: Add myself to pse networking maintainer Kory Maincent
2024-04-09 15:04 ` [PATCH net-next v7 10/17] net: pse-pd: Add support for PSE PIs Kory Maincent
2024-04-09 15:04 ` [PATCH net-next v7 11/17] dt-bindings: net: pse-pd: Add another way of describing several " Kory Maincent
2024-04-09 17:08 ` Rob Herring
2024-04-09 15:04 ` [PATCH net-next v7 12/17] net: pse-pd: Add support for setup_pi_matrix callback Kory Maincent
2024-04-09 15:04 ` [PATCH net-next v7 13/17] net: pse-pd: Use regulator framework within PSE framework Kory Maincent
2024-04-09 21:16 ` Jakub Kicinski [this message]
2024-04-10 8:09 ` Kory Maincent
2024-04-09 15:04 ` [PATCH net-next v7 14/17] dt-bindings: net: pse-pd: Add bindings for PD692x0 PSE controller Kory Maincent
2024-04-09 15:04 ` [PATCH net-next v7 15/17] net: pse-pd: Add PD692x0 PSE controller driver Kory Maincent
2024-04-09 15:04 ` [PATCH net-next v7 16/17] dt-bindings: net: pse-pd: Add bindings for TPS23881 PSE controller Kory Maincent
2024-04-09 15:04 ` [PATCH net-next v7 17/17] net: pse-pd: Add TI TPS23881 PSE controller driver Kory Maincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240409141621.392bd34b@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dentproject@linuxfoundation.org \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kory.maincent@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=mcgrof@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=russ.weight@linux.dev \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).