From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3F63158851; Tue, 9 Apr 2024 21:16:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712697383; cv=none; b=A6RMMKrzhAVbrVhsOhEmVJ51QLdCrcFPyreJZAOcn76lI0EEArxwQtLDKfw/rXzIdnof2jlH87g+kpGWZzEkYC1kusn2iDPSVh7Ez6hgpencFKDPTEpLbMoUjse0rfnympL/HwdJp3NYaUeVZUY4wuDCnZ4Es1HzJiYt+PNtiuQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712697383; c=relaxed/simple; bh=xeavq2Gb3F1c/5wmYZH2baldLPex/RujkQlSGyUMlMI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=PZCm+evtekY/X+MGkZAmd7j+tVqVgtFSf2RnExnFwp9Ab4hdaq/0BODKVU+Rr6gLYyXtTkHfmSDSNEkP4rlmqZOQwGMkHP7vBo4mDXYXTT5X0XffjbV6klw1NoTzLZE/TKUE0fOov+Vd326rIYOce1acFvA38zfK22BNcCaNIJw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aMGh6szq; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aMGh6szq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19DA7C43390; Tue, 9 Apr 2024 21:16:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712697383; bh=xeavq2Gb3F1c/5wmYZH2baldLPex/RujkQlSGyUMlMI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=aMGh6szqtH7TmNpSsLX4qbLmYjFYjKcz2ZjhBeO7cyQ0LijA2GRHez0PAwOpudg6+ brewFq94uC5EHt893rZ2rx32JrrchuViKyKcdJZzyx6LXHecTOmVIIfg/a2pFXtpv5 VdP42+jFZrc6kamwsnBQW9X+Ff1IBlODSJ/pwgu3Ee6BsgHvqxM8G6Jttvn9LrlTpg DHi8dGYeYSLFdgjra9vTlKBfwXT/3wIpEBt67p8l6C+W1cfXpVDrW9HjsdUh8qgf3N qBE7HswHhqOHRQjTr/p1TyD6ZwiM1wkmdWdR9syr9Qmk2H8Zai/m/383VWYQPaYtRS kxLK1KWsoaeQw== Date: Tue, 9 Apr 2024 14:16:21 -0700 From: Jakub Kicinski To: Kory Maincent Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , Jonathan Corbet , Luis Chamberlain , Russ Weight , Greg Kroah-Hartman , "Rafael J. Wysocki" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Oleksij Rempel , Mark Brown , Frank Rowand , Andrew Lunn , Heiner Kallweit , Russell King , Thomas Petazzoni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, devicetree@vger.kernel.org, Dent Project , kernel@pengutronix.de, Maxime Chevallier Subject: Re: [PATCH net-next v7 13/17] net: pse-pd: Use regulator framework within PSE framework Message-ID: <20240409141621.392bd34b@kernel.org> In-Reply-To: <20240409-feature_poe-v7-13-11e38efd4dee@bootlin.com> References: <20240409-feature_poe-v7-0-11e38efd4dee@bootlin.com> <20240409-feature_poe-v7-13-11e38efd4dee@bootlin.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue, 09 Apr 2024 17:04:03 +0200 Kory Maincent wrote: > -static inline struct pse_control *of_pse_control_get(struct device_node = *node) > +static inline struct pse_control *of_pse_control_get(struct device *dev, > + struct device_node *node) One of the related patches breaks the build: drivers/net/mdio/fwnode_mdio.c: In function =E2=80=98fwnode_find_pse_contro= l=E2=80=99: drivers/net/mdio/fwnode_mdio.c:32:35: error: passing argument 1 of =E2=80= =98of_pse_control_get=E2=80=99 from incompatible pointer type [-Werror=3Din= compatible-pointer-types] 32 | psec =3D of_pse_control_get(np); | ^~ | | | struct device_node * In file included from drivers/net/mdio/fwnode_mdio.c:13: ./include/linux/pse-pd/pse.h:157:69: note: expected =E2=80=98struct device = *=E2=80=99 but argument is of type =E2=80=98struct device_node *=E2=80=99 157 | static inline struct pse_control *of_pse_control_get(struct device = *dev, | ~~~~~~~~~~~~~~= ~^~~ drivers/net/mdio/fwnode_mdio.c:32:16: error: too few arguments to function = =E2=80=98of_pse_control_get=E2=80=99 32 | psec =3D of_pse_control_get(np); | ^~~~~~~~~~~~~~~~~~ In file included from drivers/net/mdio/fwnode_mdio.c:13: ./include/linux/pse-pd/pse.h:157:35: note: declared here 157 | static inline struct pse_control *of_pse_control_get(struct device = *dev, | ^~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors