From: Jakub Kicinski <kuba@kernel.org>
To: Yuri Benditovich <yuri.benditovich@daynix.com>
Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
Jason Wang <jasowang@redhat.com>,
yan@daynix.com, andrew@daynix.com,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net] net: change maximum number of UDP segments to 128
Date: Tue, 9 Apr 2024 16:31:16 -0700 [thread overview]
Message-ID: <20240409163116.0b1525c5@kernel.org> (raw)
In-Reply-To: <20240406185029.93335-1-yuri.benditovich@daynix.com>
CC: netdev@
On Sat, 6 Apr 2024 21:50:29 +0300 Yuri Benditovich wrote:
> Fixes: fc8b2a619469378 ("net: more strict VIRTIO_NET_HDR_GSO_UDP_L4 validation")
>
Fixes: line goes right above your sign-off, no empty lines in between
them.
> The mentioned above commit adds check of potential number
> of UDP segments vs UDP_MAX_SEGMENTS in linux/virtio_net.h.
> After this change certification test of USO guest-to-guest
> transmit on Windows driver for virtio-net device fails,
> for example with packet size of ~64K and mss of 536 bytes.
> In general the USO should not be more restrictive than TSO.
> Indeed, in case of unreasonably small mss a lot of segments
> can cause queue overflow and packet loss on the destination.
> Limit of 128 segments is good for any practical purpose,
> with minimal meaningful mss of 536 the maximal UDP packet will
> be divided to ~120 segments.
>
> Signed-off-by: Yuri Benditovich <yuri.benditovich@daynix.com>
next parent reply other threads:[~2024-04-09 23:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240406185029.93335-1-yuri.benditovich@daynix.com>
2024-04-09 23:31 ` Jakub Kicinski [this message]
[not found] ` <CACGkMEvKwh6GdkPzVyUDxODyCJQwHKFNJnOwCCRXurjUR=6aFQ@mail.gmail.com>
[not found] ` <CAOEp5OdvTAzi830Kp1JiUbdDiq77oN3-5tD-hZXAaai4EUDTcQ@mail.gmail.com>
[not found] ` <CACGkMEtKnu4MmPvdrxktygFB8B5Abn7rTkNcmU-cO-3MRkZgNg@mail.gmail.com>
[not found] ` <CAOEp5OdhBJabrTTAZLxTgBvkJkQ3wKDGG-CYrimXd1dY9qqdkA@mail.gmail.com>
[not found] ` <CACGkMEuEsCuRKUiAoUmb1LBL9pygGwEhXaivyx3m_sp9KqU27A@mail.gmail.com>
[not found] ` <CAOEp5OeRvZny1fJY=T=Gc82Spux=fEeHsdfNVMje6Fr-dPXXVA@mail.gmail.com>
[not found] ` <CACGkMEtSFEOKhhewvv6_pyw0RHvs0QqfAjrpjmfPxVK8RGm3JA@mail.gmail.com>
[not found] ` <CAOEp5OepdfMhuh5rcKhadb4FBaxe4uEsxb_KFvEFW3q6Rj1MDA@mail.gmail.com>
2024-04-11 5:53 ` [PATCH net] net: change maximum number of UDP segments to 128 Jason Wang
2024-04-11 9:39 ` Yuri Benditovich
2024-04-12 2:59 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240409163116.0b1525c5@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@daynix.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jasowang@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=willemdebruijn.kernel@gmail.com \
--cc=yan@daynix.com \
--cc=yuri.benditovich@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).