netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Bogendoerfer <tbogendoerfer@suse.de>
To: Simon Horman <horms@kernel.org>
Cc: Jay Vosburgh <j.vosburgh@gmail.com>,
	Andy Gospodarek <andy@greyhouse.net>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] bonding: 802.3ad: Avoid packet loss when switching aggregator
Date: Tue, 9 Apr 2024 16:34:23 +0200	[thread overview]
Message-ID: <20240409163423.7d0b8fe9@samweis> (raw)
In-Reply-To: <20240406160354.GW26556@kernel.org>

On Sat, 6 Apr 2024 17:03:54 +0100
Simon Horman <horms@kernel.org> wrote:

> On Thu, Apr 04, 2024 at 01:49:08PM +0200, Thomas Bogendoerfer wrote:
> > If selection logic decides to switch to a new aggregator it disables
> > all ports of the old aggregator, but doesn't enable ports on
> > the new aggregator. These ports will eventually be enabled when
> > the next LACPDU is received, which might take some time and without an
> > active port transmitted frames are dropped. Avoid this by enabling
> > already collected ports of the new aggregator immediately.
> > 
> > Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>  
> 
> Hi Thomas,
> 
> I will leave the technical review to Jay and others.  But as a fix, I think
> this patch warrants a Fixes tag. It should be sufficient to respond to this
> email thread with an appropriate tag.

current behavior is older than our git tree. So should I really add

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")

?

Thomas.

-- 
SUSE Software Solutions Germany GmbH
HRB 36809 (AG Nürnberg)
Geschäftsführer: Ivo Totev, Andrew McDonald, Werner Knoblich

  reply	other threads:[~2024-04-09 14:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-04 11:49 [PATCH net] bonding: 802.3ad: Avoid packet loss when switching aggregator Thomas Bogendoerfer
2024-04-06 16:03 ` Simon Horman
2024-04-09 14:34   ` Thomas Bogendoerfer [this message]
2024-04-08 16:06 ` Jay Vosburgh
2024-04-10 15:50   ` Thomas Bogendoerfer
2024-04-11  0:28     ` Jay Vosburgh
2024-04-15 16:57       ` Thomas Bogendoerfer
2024-04-11  2:44 ` Hangbin Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240409163423.7d0b8fe9@samweis \
    --to=tbogendoerfer@suse.de \
    --cc=andy@greyhouse.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=j.vosburgh@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).