netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
	Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
	netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net 1/3] net: add copy_safe_from_sockptr() helper
Date: Tue, 9 Apr 2024 17:03:32 -0700	[thread overview]
Message-ID: <20240409170332.244941a1@kernel.org> (raw)
In-Reply-To: <20240408082845.3957374-2-edumazet@google.com>

On Mon,  8 Apr 2024 08:28:43 +0000 Eric Dumazet wrote:
> + * Returns
> + *  * -EINVAL: @optlen < @ksize
> + *  * -EFAULT: access to userspace failed.
> + *  * 0 : @ksize bytes were copied

We enabled the "kdoc returns" validation, because people were nit
picking on the list. Apparently there needs to be a colon at the end:

          here
          v
 * Returns:
 *  * -EINVAL: @optlen < @ksize

Fixed when applying.

  reply	other threads:[~2024-04-10  0:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-08  8:28 [PATCH net 0/3] net: start to replace copy_from_sockptr() Eric Dumazet
2024-04-08  8:28 ` [PATCH net 1/3] net: add copy_safe_from_sockptr() helper Eric Dumazet
2024-04-10  0:03   ` Jakub Kicinski [this message]
2024-04-08  8:28 ` [PATCH net 2/3] mISDN: fix MISDN_TIME_STAMP handling Eric Dumazet
2024-04-08  8:28 ` [PATCH net 3/3] nfc: llcp: fix nfc_llcp_setsockopt() unsafe copies Eric Dumazet
2024-04-09  6:17   ` Krzysztof Kozlowski
2024-04-10  0:30 ` [PATCH net 0/3] net: start to replace copy_from_sockptr() patchwork-bot+netdevbpf
2024-04-12 17:23 ` David Laight

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240409170332.244941a1@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=horms@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).