From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1318F391; Wed, 10 Apr 2024 01:27:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712712448; cv=none; b=OoXLkCNjMSU7enuyxLxOYZ38V9CvDeGgCZPsC75zpZ1NDP5d8eGAuQvfMdQabdVluCsNAK9KemGUri2JB+6chm2HswzpOVwJ6wcKAyYmk+BECycPI8dSrrDdfBzVbl6f7OHdhSpKzOs6U/+7uZu1S53UDN061qYvVkHs5N6eOMA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712712448; c=relaxed/simple; bh=q2tSh/sYbSxvQVVhorLxNwZpuvP0uBvNHMIk0JP8zUI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=soe2MkEJrENnecBmvsCx+BsIMlzb+ngVs5VNroitw3ToRDuVS2vfHiNUFP92Gdl56pi/jwCavlqpdBDa7WXkLvsBSE893AF9JQz56oBsyWKr99jrgsmbrSDPoKZL8jVKP7P4+vu4u13eU2NcRxHkgZd+Ygk/2iK2P/veLYW+c8o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=riJ6917K; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="riJ6917K" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 94883C433C7; Wed, 10 Apr 2024 01:27:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712712447; bh=q2tSh/sYbSxvQVVhorLxNwZpuvP0uBvNHMIk0JP8zUI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=riJ6917KTbycUcwzl5X+15b0Es1e8f6b1ydfFMc2/2UZX9J7juMtDtyeb9zufa3AN 4K2mxe+Bm7dDpAyOvfSLhfabriZyfl3DNlyynCWN4pJw1u7tncJ8hcZ2DsLpP319SU mWf1DiKy+AC64RMLtOXB8m65+HHOrYye8c0aqORzHyARNF0F2VK/9TyDJESd9NPg6h UI5rLDHF7Kko8/02PoNm5XEBn4JZfQz9R4HPFAsQx/BpPOf7ChmCAI9fhvD6Z70Zhc SL4pX+CNajtbzKxTEo43vKJesKBPSBv9paBYshU4kHf+0AFdm2M7K96zBDdFCsxrvM /O+SdeDgXzmgA== Date: Tue, 9 Apr 2024 18:27:25 -0700 From: Jakub Kicinski To: Kory Maincent Cc: Florian Fainelli , Broadcom internal kernel review list , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Paolo Abeni , Richard Cochran , Radu Pirea , Jay Vosburgh , Andy Gospodarek , Nicolas Ferre , Claudiu Beznea , Willem de Bruijn , Jonathan Corbet , Horatiu Vultur , UNGLinuxDriver@microchip.com, Simon Horman , Vladimir Oltean , Thomas Petazzoni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Maxime Chevallier , Rahul Rameshbabu , Alexandra Winter Subject: Re: [PATCH net-next v10 07/13] net: Add struct kernel_ethtool_ts_info Message-ID: <20240409182725.139856d5@kernel.org> In-Reply-To: <20240409-feature_ptp_netnext-v10-7-0fa2ea5c89a9@bootlin.com> References: <20240409-feature_ptp_netnext-v10-0-0fa2ea5c89a9@bootlin.com> <20240409-feature_ptp_netnext-v10-7-0fa2ea5c89a9@bootlin.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 09 Apr 2024 10:26:29 +0200 Kory Maincent wrote: > In prevision to add new UAPI for hwtstamp we will be limited to the struct > ethtool_ts_info that is currently passed in fixed binary format through the > ETHTOOL_GET_TS_INFO ethtool ioctl. It would be good if new kernel code > already started operating on an extensible kernel variant of that > structure, similar in concept to struct kernel_hwtstamp_config vs struct > hwtstamp_config. > > Since struct ethtool_ts_info is in include/uapi/linux/ethtool.h, here > we introduce the kernel-only structure in include/linux/ethtool.h. > The manual copy is then made in the function called by ETHTOOL_GET_TS_INFO. This one now conflicts :( Applying: net: Add struct kernel_ethtool_ts_info error: sha1 information is lacking or useless (drivers/net/phy/marvell_ptp.c). error: could not build fake ancestor -- pw-bot: cr