From: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>
To: netdev@vger.kernel.org
Cc: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
linux-kernel@vger.kernel.org,
"Louis Peens" <louis.peens@corigine.com>,
"Yanguo Li" <yanguo.li@corigine.com>,
oss-drivers@corigine.com,
"Taras Chornyi" <taras.chornyi@plvision.eu>,
"Woojung Huh" <woojung.huh@microchip.com>,
UNGLinuxDriver@microchip.com, "Andrew Lunn" <andrew@lunn.ch>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Vladimir Oltean" <olteanv@gmail.com>,
"Edward Cree" <ecree.xilinx@gmail.com>,
"Jamal Hadi Salim" <jhs@mojatatu.com>,
"Cong Wang" <xiyou.wangcong@gmail.com>,
"Jiri Pirko" <jiri@resnulli.us>
Subject: [PATCH net-next v2 4/4] net: dsa: microchip: ksz9477: flower: validate control flags
Date: Wed, 10 Apr 2024 09:32:25 +0000 [thread overview]
Message-ID: <20240410093235.5334-5-ast@fiberby.net> (raw)
In-Reply-To: <20240410093235.5334-1-ast@fiberby.net>
Add check for unsupported control flags.
Only compile-tested, no access to HW.
Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
---
drivers/net/dsa/microchip/ksz9477_tc_flower.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/dsa/microchip/ksz9477_tc_flower.c b/drivers/net/dsa/microchip/ksz9477_tc_flower.c
index 8b2f5be667e01..ca7830ab168ac 100644
--- a/drivers/net/dsa/microchip/ksz9477_tc_flower.c
+++ b/drivers/net/dsa/microchip/ksz9477_tc_flower.c
@@ -124,6 +124,9 @@ static int ksz9477_flower_parse_key(struct ksz_device *dev, int port,
return -EOPNOTSUPP;
}
+ if (flow_rule_match_has_control_flags(rule, extack))
+ return -EOPNOTSUPP;
+
if (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_BASIC) ||
flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_ETH_ADDRS)) {
ret = ksz9477_flower_parse_key_l2(dev, port, extack, rule,
--
2.43.0
prev parent reply other threads:[~2024-04-10 9:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 9:32 [PATCH net-next v2 0/4] flower: validate control flags Asbjørn Sloth Tønnesen
2024-04-10 9:32 ` [PATCH net-next v2 1/4] flow_offload: add control flag checking helpers Asbjørn Sloth Tønnesen
2024-04-10 11:27 ` Asbjørn Sloth Tønnesen
2024-04-11 6:24 ` Louis Peens
2024-04-10 9:32 ` [PATCH net-next v2 2/4] nfp: flower: fix check for unsupported control flags Asbjørn Sloth Tønnesen
2024-04-11 6:59 ` Louis Peens
2024-04-10 9:32 ` [PATCH net-next v2 3/4] net: prestera: flower: validate " Asbjørn Sloth Tønnesen
2024-04-10 9:32 ` Asbjørn Sloth Tønnesen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240410093235.5334-5-ast@fiberby.net \
--to=ast@fiberby.net \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=louis.peens@corigine.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=oss-drivers@corigine.com \
--cc=pabeni@redhat.com \
--cc=taras.chornyi@plvision.eu \
--cc=woojung.huh@microchip.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yanguo.li@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).