From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH net-next] tcp: tweak tcp_sock_write_txrx size assertion
Date: Wed, 10 Apr 2024 17:49:59 +0300 [thread overview]
Message-ID: <20240410144959.i6forc4wqufwfqpr@skbuf> (raw)
In-Reply-To: <20240409140914.4105429-1-edumazet@google.com>
On Tue, Apr 09, 2024 at 02:09:14PM +0000, Eric Dumazet wrote:
> I forgot 32bit arches might have 64bit alignment for u64
> fields.
>
> tcp_sock_write_txrx group does not contain pointers,
> but two u64 fields. It is possible that on 32bit kernel,
> a 32bit hole is before tp->tcp_clock_cache.
>
> I will try to remember a group can be bigger on 32bit
> kernels in the future.
>
> With help from Vladimir Oltean.
>
> Fixes: d2c3a7eb1afa ("tcp: more struct tcp_sock adjustments")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202404082207.HCEdQhUO-lkp@intel.com/
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
Tested-by: Vladimir Oltean <vladimir.oltean@nxp.com>
next prev parent reply other threads:[~2024-04-10 14:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 14:09 [PATCH net-next] tcp: tweak tcp_sock_write_txrx size assertion Eric Dumazet
2024-04-10 14:49 ` Vladimir Oltean [this message]
2024-04-11 2:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240410144959.i6forc4wqufwfqpr@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox