From: Jakub Kicinski <kuba@kernel.org>
To: Alexander Lobakin <aleksander.lobakin@intel.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, David Ahern <dsahern@kernel.org>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
Andrew Lunn <andrew@lunn.ch>,
<nex.sw.ncis.osdt.itp.upstreaming@intel.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFC net-next 7/7] netdev_features: convert NETIF_F_FCOE_MTU to IFF_FCOE_MTU
Date: Thu, 11 Apr 2024 07:47:09 -0700 [thread overview]
Message-ID: <20240411074709.249b3482@kernel.org> (raw)
In-Reply-To: <1f14cb75-ee6b-4a7d-9041-23a8cfcd8476@intel.com>
On Thu, 11 Apr 2024 12:28:08 +0200 Alexander Lobakin wrote:
> > Any reason not to make it a bitfield? I haven't looked at the longer
> > patches but this one seems to be used like a basic bool.
>
> This whole enum could be made as bitfields, should we convert it? Would
> be a big patch tho ._.
As always, I haven't investigated closely :) But my thinking was -
we are at 34 bits in priv. We just need to convert 2 of them to
a bitfield, pick two with fewest uses. Then we can downgrade
the field to u32 from ulonglong, and we can carry on adding bitfields?
> > But this definitely _is_ a uAPI change, right?
>
> Why?
It will be user visible, ethtool -k is losing a field.
Whether that's actually going to break anything depends on how silly
user space is.
As Andrew pointed out, definitely something that should be called out
in the commit message.
next prev parent reply other threads:[~2024-04-11 14:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-05 13:37 [PATCH RFC net-next 0/7] netdev_features: start cleaning netdev_features_t up Alexander Lobakin
2024-04-05 13:37 ` [PATCH RFC net-next 1/7] netdev_features: remove unused __UNUSED_NETIF_F_1 Alexander Lobakin
2024-04-05 14:12 ` Andrew Lunn
2024-04-05 15:15 ` Alexander Lobakin
2024-04-05 15:41 ` Andrew Lunn
2024-04-05 13:37 ` [PATCH RFC net-next 2/7] netdev_features: convert NETIF_F_LLTX to priv_flag IFF_LLTX Alexander Lobakin
2024-04-15 14:37 ` Simon Horman
2024-04-16 12:39 ` Alexander Lobakin
2024-04-05 13:37 ` [PATCH RFC net-next 3/7] netdevice: introduce IFF_LOGICAL as (IFF_NO_QUEUE | IFF_LLTX) Alexander Lobakin
2024-04-09 2:32 ` Jakub Kicinski
2024-04-11 10:29 ` Alexander Lobakin
2024-04-05 13:37 ` [PATCH RFC net-next 4/7] netdev_features: convert NETIF_F_NETNS_LOCAL to IFF_NETNS_LOCAL Alexander Lobakin
2024-04-05 13:37 ` [PATCH RFC net-next 5/7] netdev_features: convert NETIF_F_HIGHDMA to priv_flag IFF_HIGHDMA Alexander Lobakin
2024-04-15 14:35 ` Simon Horman
2024-04-05 13:37 ` [PATCH RFC net-next 6/7] netdev_features: convert NETIF_F_VLAN_CHALLENGED to IFF_VLAN_CHALLENGED Alexander Lobakin
2024-04-05 13:37 ` [PATCH RFC net-next 7/7] netdev_features: convert NETIF_F_FCOE_MTU to IFF_FCOE_MTU Alexander Lobakin
2024-04-09 2:38 ` Jakub Kicinski
2024-04-11 10:28 ` Alexander Lobakin
2024-04-11 14:20 ` Andrew Lunn
2024-04-11 14:47 ` Jakub Kicinski [this message]
2024-04-16 12:45 ` Alexander Lobakin
2024-04-16 14:19 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240411074709.249b3482@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nex.sw.ncis.osdt.itp.upstreaming@intel.com \
--cc=pabeni@redhat.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).