From: Jason Xing <kerneljasonxing@gmail.com>
To: edumazet@google.com, dsahern@kernel.org, matttbe@kernel.org,
martineau@kernel.org, geliang@kernel.org, kuba@kernel.org,
pabeni@redhat.com, davem@davemloft.net, rostedt@goodmis.org,
mhiramat@kernel.org, mathieu.desnoyers@efficios.com,
atenart@kernel.org
Cc: mptcp@lists.linux.dev, netdev@vger.kernel.org,
kerneljasonxing@gmail.com, Jason Xing <kernelxing@tencent.com>
Subject: [PATCH net-next v4 5/6] mptcp: support rstreason for passive reset
Date: Thu, 11 Apr 2024 19:56:29 +0800 [thread overview]
Message-ID: <20240411115630.38420-6-kerneljasonxing@gmail.com> (raw)
In-Reply-To: <20240411115630.38420-1-kerneljasonxing@gmail.com>
From: Jason Xing <kernelxing@tencent.com>
It relys on what reset options in the skb are as rfc8684 says. Reusing
this logic can save us much energy. This patch replaces most of the prior
NOT_SPECIFIED reasons.
Signed-off-by: Jason Xing <kernelxing@tencent.com>
---
net/mptcp/subflow.c | 20 +++++++++++++++-----
1 file changed, 15 insertions(+), 5 deletions(-)
diff --git a/net/mptcp/subflow.c b/net/mptcp/subflow.c
index ba0a252c113f..25eaad94cb79 100644
--- a/net/mptcp/subflow.c
+++ b/net/mptcp/subflow.c
@@ -308,8 +308,12 @@ static struct dst_entry *subflow_v4_route_req(const struct sock *sk,
return dst;
dst_release(dst);
- if (!req->syncookie)
- tcp_request_sock_ops.send_reset(sk, skb, SK_RST_REASON_NOT_SPECIFIED);
+ if (!req->syncookie) {
+ struct mptcp_ext *mpext = mptcp_get_ext(skb);
+ enum sk_rst_reason reason = convert_mptcp_reason(mpext->reset_reason);
+
+ tcp_request_sock_ops.send_reset(sk, skb, reason);
+ }
return NULL;
}
@@ -375,8 +379,12 @@ static struct dst_entry *subflow_v6_route_req(const struct sock *sk,
return dst;
dst_release(dst);
- if (!req->syncookie)
- tcp6_request_sock_ops.send_reset(sk, skb, SK_RST_REASON_NOT_SPECIFIED);
+ if (!req->syncookie) {
+ struct mptcp_ext *mpext = mptcp_get_ext(skb);
+ enum sk_rst_reason reason = convert_mptcp_reason(mpext->reset_reason);
+
+ tcp6_request_sock_ops.send_reset(sk, skb, reason);
+ }
return NULL;
}
#endif
@@ -783,6 +791,7 @@ static struct sock *subflow_syn_recv_sock(const struct sock *sk,
bool fallback, fallback_is_fatal;
struct mptcp_sock *owner;
struct sock *child;
+ enum sk_rst_reason reason;
pr_debug("listener=%p, req=%p, conn=%p", listener, req, listener->conn);
@@ -911,7 +920,8 @@ static struct sock *subflow_syn_recv_sock(const struct sock *sk,
tcp_rsk(req)->drop_req = true;
inet_csk_prepare_for_destroy_sock(child);
tcp_done(child);
- req->rsk_ops->send_reset(sk, skb, SK_RST_REASON_NOT_SPECIFIED);
+ reason = convert_mptcp_reason(mptcp_get_ext(skb)->reset_reason);
+ req->rsk_ops->send_reset(sk, skb, reason);
/* The last child reference will be released by the caller */
return child;
--
2.37.3
next prev parent reply other threads:[~2024-04-11 11:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 11:56 [PATCH net-next v4 0/6] Implement reset reason mechanism to detect Jason Xing
2024-04-11 11:56 ` [PATCH net-next v4 1/6] net: introduce rstreason to detect why the RST is sent Jason Xing
2024-04-11 11:56 ` [PATCH net-next v4 2/6] rstreason: prepare for passive reset Jason Xing
2024-04-11 11:56 ` [PATCH net-next v4 3/6] rstreason: prepare for active reset Jason Xing
2024-04-16 8:01 ` Paolo Abeni
2024-04-16 8:27 ` Jason Xing
2024-04-11 11:56 ` [PATCH net-next v4 4/6] tcp: support rstreason for passive reset Jason Xing
2024-04-16 6:34 ` Eric Dumazet
2024-04-16 7:45 ` Jason Xing
2024-04-16 12:24 ` Jason Xing
2024-04-16 20:22 ` Matthieu Baerts
2024-04-17 0:23 ` Jason Xing
2024-04-11 11:56 ` Jason Xing [this message]
2024-04-16 6:33 ` [PATCH net-next v4 5/6] mptcp: " Eric Dumazet
2024-04-16 7:45 ` Jason Xing
2024-04-16 8:04 ` Paolo Abeni
2024-04-16 8:19 ` Jason Xing
2024-04-11 11:56 ` [PATCH net-next v4 6/6] rstreason: make it work in trace world Jason Xing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240411115630.38420-6-kerneljasonxing@gmail.com \
--to=kerneljasonxing@gmail.com \
--cc=atenart@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=geliang@kernel.org \
--cc=kernelxing@tencent.com \
--cc=kuba@kernel.org \
--cc=martineau@kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=matttbe@kernel.org \
--cc=mhiramat@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).