From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, pabeni@redhat.com,
Stefano Brivio <sbrivio@redhat.com>,
Ilya Maximets <i.maximets@ovn.org>,
dsahern@kernel.org, donald.hunter@gmail.com
Subject: Re: [PATCH net] inet: bring NLM_DONE out to a separate recv() again
Date: Thu, 11 Apr 2024 11:57:48 -0700 [thread overview]
Message-ID: <20240411115748.05faa636@kernel.org> (raw)
In-Reply-To: <CANn89iJne2+k+MJQzu1U7vO6eEbTLjD7QQxSG6hPgZ1i7+AutA@mail.gmail.com>
On Thu, 11 Apr 2024 20:42:45 +0200 Eric Dumazet wrote:
> My plan was to perform this generically from netlink_dump_done().
>
> This would still avoid calling a RTNL-enabled-dump() again if EOF has
> been met already.
>
> A sysctl could opt-in for the coalescing, if there is interest.
I'd prefer to keep hacks contained to the few places that need them.
Netlink is full of strange quirks, I don't think this one deserves
a sysctl.
next prev parent reply other threads:[~2024-04-11 18:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 18:02 [PATCH net] inet: bring NLM_DONE out to a separate recv() again Jakub Kicinski
2024-04-11 18:42 ` Eric Dumazet
2024-04-11 18:57 ` Jakub Kicinski [this message]
2024-04-11 19:35 ` Ilya Maximets
2024-06-17 15:09 ` Ilya Maximets
2024-06-17 16:36 ` Jakub Kicinski
2024-06-17 17:05 ` Ilya Maximets
2024-04-11 19:45 ` David Ahern
2024-04-11 21:01 ` Jakub Kicinski
2024-04-11 21:14 ` David Ahern
2024-04-12 17:22 ` Stefano Brivio
2024-04-12 17:38 ` Ilya Maximets
2024-04-12 18:03 ` Stefano Brivio
2024-04-12 18:22 ` Ilya Maximets
2024-04-15 9:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240411115748.05faa636@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=i.maximets@ovn.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).