From: Jakub Kicinski <kuba@kernel.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
netdev@vger.kernel.org,
Jakub Buchocki <jakubx.buchocki@intel.com>,
Mateusz Pacuszka <mateuszx.pacuszka@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Lukasz Plachno <lukasz.plachno@intel.com>,
Jacob Keller <jacob.e.keller@intel.com>,
Simon Horman <horms@kernel.org>,
Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com>
Subject: Re: [PATCH net-next 2/4] ice: Implement 'flow-type ether' rules
Date: Thu, 11 Apr 2024 20:06:08 -0700 [thread overview]
Message-ID: <20240411200608.2fcf7e36@kernel.org> (raw)
In-Reply-To: <20240411173846.157007-3-anthony.l.nguyen@intel.com>
On Thu, 11 Apr 2024 10:38:42 -0700 Tony Nguyen wrote:
> +/**
> + * ice_set_fdir_vlan_seg
> + * @seg: flow segment for programming
> + * @ext_masks: masks for additional RX flow fields
> + */
kerne-doc is not on board (note that we started using the -Wall flag
when running the script):
drivers/net/ethernet/intel/ice/ice_ethtool_fdir.c:1285: warning: missing initial short description on line:
* ice_set_fdir_vlan_seg
drivers/net/ethernet/intel/ice/ice_ethtool_fdir.c:1292: warning: No description found for return value of 'ice_set_fdir_vlan_seg'
next prev parent reply other threads:[~2024-04-12 3:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 17:38 [PATCH net-next 0/4][pull request] Intel Wired LAN Driver Updates 2024-04-11 (ice) Tony Nguyen
2024-04-11 17:38 ` [PATCH net-next 1/4] ice: Remove unnecessary argument from ice_fdir_comp_rules() Tony Nguyen
2024-04-11 17:38 ` [PATCH net-next 2/4] ice: Implement 'flow-type ether' rules Tony Nguyen
2024-04-12 3:06 ` Jakub Kicinski [this message]
2024-04-12 9:41 ` Plachno, Lukasz
2024-04-12 15:40 ` Tony Nguyen
2024-04-11 17:38 ` [PATCH net-next 3/4] ice: set vf->num_msix in ice_initialize_vf_entry() Tony Nguyen
2024-04-11 17:38 ` [PATCH net-next 4/4] ice: store VF relative MSI-X index in q_vector->vf_reg_idx Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240411200608.2fcf7e36@kernel.org \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=himasekharx.reddy.pucha@intel.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=jakubx.buchocki@intel.com \
--cc=lukasz.plachno@intel.com \
--cc=mateuszx.pacuszka@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).