From: Jakub Kicinski <kuba@kernel.org>
To: Marek Vasut <marex@denx.de>
Cc: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Eric Dumazet" <edumazet@google.com>,
"Mark Brown" <broonie@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Ratheesh Kannoth" <rkannoth@marvell.com>,
"Ronald Wahl" <ronald.wahl@raritan.com>,
"Simon Horman" <horms@kernel.org>
Subject: Re: [PATCH net v2 2/2] net: ks8851: Handle softirqs at the end of IRQ thread to fix hang
Date: Fri, 12 Apr 2024 07:52:20 -0700 [thread overview]
Message-ID: <20240412075220.17943537@kernel.org> (raw)
In-Reply-To: <a8e28385-5b92-4149-be0c-cfce6394fbc2@denx.de>
On Fri, 12 Apr 2024 13:29:04 +0200 Marek Vasut wrote:
> >> irq_thread_fn from irq_thread
> >> irq_thread from kthread
> >> kthread from ret_from_fork
> >
> > These lines are unneeded (in case you need a new version, you can drop them).
>
> I just got back and going through a mountain of email, I see Jakub
> already picked the V2, so, noted for next time. Thank you !
Whether the stack trace is for a hard IRQ or threaded IRQ is the first
thing I looked for when reviewing. Change is about the calling context.
So I figured while not strictly necessary, in this particular case,
these lines may be helpful for people eyeballing the change...
In general, yes, trimming the bottom of the stack is good hygiene.
next prev parent reply other threads:[~2024-04-12 14:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-05 20:30 [PATCH net v2 1/2] net: ks8851: Inline ks8851_rx_skb() Marek Vasut
2024-04-05 20:30 ` [PATCH net v2 2/2] net: ks8851: Handle softirqs at the end of IRQ thread to fix hang Marek Vasut
2024-04-08 14:52 ` Andy Shevchenko
2024-04-12 11:29 ` Marek Vasut
2024-04-12 14:52 ` Jakub Kicinski [this message]
2024-04-12 14:54 ` Jakub Kicinski
2024-04-12 15:47 ` Andy Shevchenko
2024-04-09 3:30 ` [PATCH net v2 1/2] net: ks8851: Inline ks8851_rx_skb() patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240412075220.17943537@kernel.org \
--to=kuba@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=davem@davemloft.net \
--cc=dmitry.torokhov@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=marex@denx.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rkannoth@marvell.com \
--cc=ronald.wahl@raritan.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).