* [PATCH ipsec] xfrm: fix possible derferencing in error path
@ 2024-04-10 17:27 Antony Antony
2024-04-12 13:42 ` Simon Horman
2024-04-22 4:45 ` Steffen Klassert
0 siblings, 2 replies; 3+ messages in thread
From: Antony Antony @ 2024-04-10 17:27 UTC (permalink / raw)
To: Steffen Klassert, netdev, Herbert Xu
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Antony Antony, Dan Carpenter
Fix derferencing pointer when xfrm_policy_lookup_bytype returns an
error.
Fixes: 63b21caba17e ("xfrm: introduce forwarding of ICMP Error messages")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/kernel-janitors/f6ef0d0d-96de-4e01-9dc3-c1b3a6338653@moroto.mountain/
Signed-off-by: Antony Antony <antony.antony@secunet.com>
---
net/xfrm/xfrm_policy.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c
index 6affe5cd85d8..53d8fabfa685 100644
--- a/net/xfrm/xfrm_policy.c
+++ b/net/xfrm/xfrm_policy.c
@@ -3593,6 +3593,8 @@ xfrm_policy *xfrm_in_fwd_icmp(struct sk_buff *skb,
return pol;
pol = xfrm_policy_lookup(net, &fl1, family, XFRM_POLICY_FWD, if_id);
+ if (IS_ERR(pol))
+ pol = NULL;
}
return pol;
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH ipsec] xfrm: fix possible derferencing in error path
2024-04-10 17:27 [PATCH ipsec] xfrm: fix possible derferencing in error path Antony Antony
@ 2024-04-12 13:42 ` Simon Horman
2024-04-22 4:45 ` Steffen Klassert
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2024-04-12 13:42 UTC (permalink / raw)
To: Antony Antony
Cc: Steffen Klassert, netdev, Herbert Xu, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Dan Carpenter
On Wed, Apr 10, 2024 at 07:27:12PM +0200, Antony Antony wrote:
> Fix derferencing pointer when xfrm_policy_lookup_bytype returns an
> error.
>
> Fixes: 63b21caba17e ("xfrm: introduce forwarding of ICMP Error messages")
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Closes: https://lore.kernel.org/kernel-janitors/f6ef0d0d-96de-4e01-9dc3-c1b3a6338653@moroto.mountain/
> Signed-off-by: Antony Antony <antony.antony@secunet.com>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH ipsec] xfrm: fix possible derferencing in error path
2024-04-10 17:27 [PATCH ipsec] xfrm: fix possible derferencing in error path Antony Antony
2024-04-12 13:42 ` Simon Horman
@ 2024-04-22 4:45 ` Steffen Klassert
1 sibling, 0 replies; 3+ messages in thread
From: Steffen Klassert @ 2024-04-22 4:45 UTC (permalink / raw)
To: Antony Antony
Cc: netdev, Herbert Xu, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Dan Carpenter
On Wed, Apr 10, 2024 at 07:27:12PM +0200, Antony Antony wrote:
> Fix derferencing pointer when xfrm_policy_lookup_bytype returns an
> error.
>
> Fixes: 63b21caba17e ("xfrm: introduce forwarding of ICMP Error messages")
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Closes: https://lore.kernel.org/kernel-janitors/f6ef0d0d-96de-4e01-9dc3-c1b3a6338653@moroto.mountain/
> Signed-off-by: Antony Antony <antony.antony@secunet.com>
Applied, thanks a lot!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-22 4:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-10 17:27 [PATCH ipsec] xfrm: fix possible derferencing in error path Antony Antony
2024-04-12 13:42 ` Simon Horman
2024-04-22 4:45 ` Steffen Klassert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).