From: Richard Gobert <richardbgobert@gmail.com>
To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, willemdebruijn.kernel@gmail.com,
dsahern@kernel.org, aleksander.lobakin@intel.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Richard Gobert <richardbgobert@gmail.com>
Subject: [PATCH net v1 0/2] net: gro: add flush/flush_id checks and fix wrong offset in udp
Date: Fri, 12 Apr 2024 17:21:18 +0200 [thread overview]
Message-ID: <20240412152120.115067-1-richardbgobert@gmail.com> (raw)
This series fixes a bug in the complete phase of UDP in GRO, in which
socket lookup fails due to using network_header when parsing encapsulated
packets. The fix is to pass p_off (previous offset, offset to the start of
the previous layer) parameter in *_gro_complete.
The original series includes a change to a vxlan test which adds the local
parameter to prevent similar future bugs. I plan to submit it separately
to net-next.
In addition p->flush/flush_id should be checked in relevant UDP flows. Same
logic from tcp_gro_receive is applied for the relevant flows in
udp_gro_receive_segment.
This series is part of a previously submitted series to net-next:
https://lore.kernel.org/all/20240410153423.107381-1-richardbgobert@gmail.com/
Richard Gobert (2):
net: gro: add flush check in udp_gro_receive_segment
net: gro: add p_off param in *_gro_complete
drivers/net/geneve.c | 7 +++---
drivers/net/vxlan/vxlan_core.c | 11 ++++++----
include/linux/etherdevice.h | 2 +-
include/linux/netdevice.h | 3 ++-
include/linux/udp.h | 2 +-
include/net/gro.h | 11 +++++-----
include/net/inet_common.h | 2 +-
include/net/tcp.h | 6 ++++--
include/net/udp.h | 8 +++----
include/net/udp_tunnel.h | 2 +-
net/8021q/vlan_core.c | 4 ++--
net/core/gro.c | 2 +-
net/ethernet/eth.c | 4 ++--
net/ipv4/af_inet.c | 8 +++----
net/ipv4/fou_core.c | 9 ++++----
net/ipv4/gre_offload.c | 5 +++--
net/ipv4/tcp_offload.c | 7 +++---
net/ipv4/udp.c | 3 ++-
net/ipv4/udp_offload.c | 39 ++++++++++++++++++++++------------
net/ipv6/ip6_offload.c | 22 ++++++++++---------
net/ipv6/tcpv6_offload.c | 7 +++---
net/ipv6/udp.c | 3 ++-
net/ipv6/udp_offload.c | 13 ++++++------
23 files changed, 105 insertions(+), 75 deletions(-)
--
2.36.1
next reply other threads:[~2024-04-12 15:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 15:21 Richard Gobert [this message]
2024-04-12 15:21 ` [PATCH net v1 1/2] net: gro: add flush check in udp_gro_receive_segment Richard Gobert
2024-04-13 18:38 ` Willem de Bruijn
2024-04-14 17:22 ` Alexander Duyck
2024-04-15 15:00 ` Willem de Bruijn
2024-04-15 15:19 ` Alexander Duyck
2024-04-15 15:35 ` Willem de Bruijn
2024-04-12 15:21 ` [PATCH net v1 2/2] net: gro: add p_off param in *_gro_complete Richard Gobert
2024-04-13 18:46 ` Willem de Bruijn
2024-04-17 13:48 ` Richard Gobert
2024-04-17 19:39 ` Willem de Bruijn
2024-04-18 15:12 ` Richard Gobert
2024-04-18 18:40 ` Willem de Bruijn
2024-04-19 15:17 ` Richard Gobert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240412152120.115067-1-richardbgobert@gmail.com \
--to=richardbgobert@gmail.com \
--cc=aleksander.lobakin@intel.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).