From: Jakub Kicinski <kuba@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
shuah@kernel.org, petrm@nvidia.com,
linux-kselftest@vger.kernel.org, willemb@google.com
Subject: Re: [PATCH net-next 5/5] selftests: drv-net: add a trivial ping test
Date: Mon, 15 Apr 2024 07:33:23 -0700 [thread overview]
Message-ID: <20240415073323.351c888b@kernel.org> (raw)
In-Reply-To: <49deeded3764fd43b9af23f2f6e1b8f4ab599910.camel@redhat.com>
On Mon, 15 Apr 2024 11:31:05 +0200 Paolo Abeni wrote:
> On Fri, 2024-04-12 at 16:37 -0700, Jakub Kicinski wrote:
> > +def ping_v4(cfg) -> None:
> > + if not cfg.v4:
> > + raise KsftXfailEx()
> > +
> > + cmd(f"ping -c 1 -W0.5 {cfg.ep_v4}")
> > + cmd(f"ping -c 1 -W0.5 {cfg.v4}", host=cfg.endpoint)
>
> Very minor nit, I personally find a bit more readable:
>
> cfg.endpoint.cmd()
>
> Which is already supported by the current infra, right?
>
> With both endpoint possibly remote could be:
>
> cfg.ep1.cmd()
> cfg.ep2.cmd()
As I said in the cover letter, I don't want to push us too much towards
classes. The argument format make local and local+remote tests look more
similar.
I could be wrong 🤷️
next prev parent reply other threads:[~2024-04-15 14:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 23:37 [PATCH net-next 0/5] selftests: drv-net: support testing with a remote system Jakub Kicinski
2024-04-12 23:37 ` [PATCH net-next 1/5] selftests: drv-net: define endpoint structures Jakub Kicinski
2024-04-14 17:04 ` Willem de Bruijn
2024-04-15 14:16 ` Jakub Kicinski
2024-04-15 15:23 ` Willem de Bruijn
2024-04-15 19:39 ` Petr Machata
2024-04-15 8:57 ` Paolo Abeni
2024-04-15 14:19 ` Jakub Kicinski
2024-04-15 16:02 ` Paolo Abeni
2024-04-15 16:11 ` Paolo Abeni
2024-04-12 23:37 ` [PATCH net-next 2/5] selftests: drv-net: add stdout to the command failed exception Jakub Kicinski
2024-04-12 23:37 ` [PATCH net-next 3/5] selftests: drv-net: factor out parsing of the env Jakub Kicinski
2024-04-12 23:37 ` [PATCH net-next 4/5] selftests: drv-net: construct environment for running tests which require an endpoint Jakub Kicinski
2024-04-14 16:45 ` Willem de Bruijn
2024-04-15 14:31 ` Jakub Kicinski
2024-04-15 15:28 ` Willem de Bruijn
2024-04-15 17:36 ` Jakub Kicinski
2024-04-15 9:28 ` Paolo Abeni
2024-04-12 23:37 ` [PATCH net-next 5/5] selftests: drv-net: add a trivial ping test Jakub Kicinski
2024-04-15 9:31 ` Paolo Abeni
2024-04-15 14:33 ` Jakub Kicinski [this message]
2024-04-15 16:09 ` Paolo Abeni
2024-04-15 15:30 ` [PATCH net-next 0/5] selftests: drv-net: support testing with a remote system Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240415073323.351c888b@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).