Netdev List
 help / color / mirror / Atom feed
From: Vladimir Oltean <olteanv@gmail.com>
To: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Vladimir Oltean <vladimir.oltean@nxp.com>,
	Claudiu Manoil <claudiu.manoil@nxp.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	UNGLinuxDriver@microchip.com,
	Florian Fainelli <f.fainelli@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Colin Foster <colin.foster@in-advantage.com>,
	netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: dsa: felix: provide own phylink MAC operations
Date: Mon, 15 Apr 2024 13:34:53 +0300	[thread overview]
Message-ID: <20240415103453.drozvtf7tnwtpiht@skbuf> (raw)
In-Reply-To: <E1rvIcO-006bQQ-Md@rmk-PC.armlinux.org.uk> <E1rvIcO-006bQQ-Md@rmk-PC.armlinux.org.uk>

On Fri, Apr 12, 2024 at 04:15:08PM +0100, Russell King (Oracle) wrote:
> Convert felix to provide its own phylink MAC operations, thus
> avoiding the shim layer in DSA's port.c.
> 
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> ---
> diff --git a/drivers/net/dsa/ocelot/ocelot_ext.c b/drivers/net/dsa/ocelot/ocelot_ext.c
> index 22187d831c4b..a8927dc7aca4 100644
> --- a/drivers/net/dsa/ocelot/ocelot_ext.c
> +++ b/drivers/net/dsa/ocelot/ocelot_ext.c
> @@ -96,6 +96,7 @@ static int ocelot_ext_probe(struct platform_device *pdev)
>  	ds->num_tx_queues = felix->info->num_tx_queues;
>  
>  	ds->ops = &felix_switch_ops;
> +	ds->phylink_mac_ops = &felix_phylink_mac_ops;

There are actually 2 more places which need this: felix_vsc9959.c,
seville_vsc9953.c.

>  	ds->priv = ocelot;
>  	felix->ds = ds;
>  	felix->tag_proto = DSA_TAG_PROTO_OCELOT;
> -- 
> 2.30.2
> 

---
pw-bot: cr

  reply	other threads:[~2024-04-15 10:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-12 15:15 [PATCH net-next] net: dsa: felix: provide own phylink MAC operations Russell King (Oracle)
2024-04-15 10:34 ` Vladimir Oltean [this message]
2024-04-15 15:24   ` Russell King (Oracle)
2024-04-15 16:01     ` Vladimir Oltean
2024-04-15 16:49       ` Russell King (Oracle)
2024-04-15 20:13         ` Vladimir Oltean
2024-04-15 21:12           ` Russell King (Oracle)
2024-04-15 13:29 ` Colin Foster
  -- strict thread matches above, loose matches on Subject: below --
2024-05-28 15:15 Russell King (Oracle)
2024-05-29 14:30 ` Vladimir Oltean
2024-05-30  2:00 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240415103453.drozvtf7tnwtpiht@skbuf \
    --to=olteanv@gmail.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=andrew@lunn.ch \
    --cc=claudiu.manoil@nxp.com \
    --cc=colin.foster@in-advantage.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox