From: Stephen Hemminger <stephen@networkplumber.org>
To: Wojciech Drewek <wojciech.drewek@intel.com>
Cc: netdev@vger.kernel.org, dsahern@gmail.com
Subject: Re: [PATCH iproute2-next v2 2/2] f_flower: implement pfcp opts
Date: Mon, 15 Apr 2024 14:52:38 -0700 [thread overview]
Message-ID: <20240415145238.0f5286a3@hermes.local> (raw)
In-Reply-To: <20240415125000.12846-3-wojciech.drewek@intel.com>
On Mon, 15 Apr 2024 14:50:00 +0200
Wojciech Drewek <wojciech.drewek@intel.com> wrote:
> } else if (key_tb[TCA_FLOWER_KEY_ENC_OPTS_PFCP]) {
> + flower_print_pfcp_opts("pfcp_opt_key",
> + key_tb[TCA_FLOWER_KEY_ENC_OPTS_PFCP],
> + key, len);
> +
> + if (msk_tb[TCA_FLOWER_KEY_ENC_OPTS_PFCP])
> + flower_print_pfcp_opts("pfcp_opt_mask",
> + msk_tb[TCA_FLOWER_KEY_ENC_OPTS_PFCP],
> + msk, len);
> +
> + flower_print_enc_parts(name, " pfcp_opts %s", attr, key,
> + msk);
> }
I find the output with pfcp_opt_key and pfcp_opt_mask encoded as hex,
awkward when JSON.
The JSON output would be more logical as something like:
"pfcp" : {
"mask": {
"type": 0x0000,
"seid": 0x1,
},
"key": {
"type": 0x10,
"seid": 0x11,
}
}
next prev parent reply other threads:[~2024-04-15 21:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 12:49 [PATCH iproute2-next v2 0/2] PFCP support Wojciech Drewek
2024-04-15 12:49 ` [PATCH iproute2-next v2 1/2] ip: PFCP device support Wojciech Drewek
2024-04-15 12:50 ` [PATCH iproute2-next v2 2/2] f_flower: implement pfcp opts Wojciech Drewek
2024-04-15 21:52 ` Stephen Hemminger [this message]
2024-04-16 10:20 ` Wojciech Drewek
2024-04-21 1:53 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240415145238.0f5286a3@hermes.local \
--to=stephen@networkplumber.org \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).