From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D54EAA3F for ; Tue, 16 Apr 2024 00:24:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713227062; cv=none; b=cBtILucOa2bGgOFM2FU0CHyS5VAcBw76yzeHoTY0mMr/qno9SoNDxE7BiE04jS7a8dgDCRufNaiB11onfgboEQGHdSZONk34LU3ICTBdfEcd9F+wF9BQ9snUXVFakRmM2IAt0bRwvBwPoFQqm1cvmwlx70Uca+RFvnqa93WYBzk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713227062; c=relaxed/simple; bh=7NneDENfzfwZVV+UlVl2c+lO/XTbTS8AXH/t0a9ORBY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=cR3Dw900v7kHNYthrpwH1Ri8YwW5v2zLDD/X3NspjaEJWdbml4Qg8GEELlTBbBxx7tOQguEcDF/PFlKY1OSw8+QttoA66zOQz3hVZ+hjaOLEjnfpuiUw6ndj+GAoc+lQPKdP763YpqHZ+wN3WH1MqzYJqwISPl02PJzJh090TTc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=s/ppAFvl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="s/ppAFvl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 38779C3277B; Tue, 16 Apr 2024 00:24:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713227062; bh=7NneDENfzfwZVV+UlVl2c+lO/XTbTS8AXH/t0a9ORBY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=s/ppAFvlvXxEJb3/NVXz9k8uKPxy6/mU6T+h83eoGPXPoQfMIDxvpELsF3EyU16Pa 2AHqvKuAKQ9II8DXD6DpankE/nO2hoZ/GvnM0DiJPjulh0umAHnNau6OWlgpSfrijT 3BcnggOK/94hQGutTWlOHQo2qCDnRNeZYEPoAYJMCIWFaVkg0uuUMG8NwDA2y95PVa 2hJM7MFvYGQsvSYqOqoQsF6j+rr0R555+D4PiN2qK0md+iDqUuRlOkPCVR6/ox/eP1 4tOH5tNIROq/GYuQhTpr0Nstxei47a45rncJvf6nfD52pIasNf5+6/mXLct8KPrVDe ViM+8ExCD6GYg== Date: Mon, 15 Apr 2024 17:24:21 -0700 From: Jakub Kicinski To: Alexander Duyck Cc: Yunsheng Lin , netdev@vger.kernel.org, Alexander Duyck , davem@davemloft.net, pabeni@redhat.com Subject: Re: [net-next PATCH 13/15] eth: fbnic: add basic Rx handling Message-ID: <20240415172421.22d13a9d@kernel.org> In-Reply-To: References: <171217454226.1598374.8971335637623132496.stgit@ahduyck-xeon-server.home.arpa> <171217496013.1598374.10126180029382922588.stgit@ahduyck-xeon-server.home.arpa> <41a39896-480b-f08d-ba67-17e129e39c0f@huawei.com> <53b80db6-f2bc-d824-ea42-4b2ac64625f2@huawei.com> <0e5e3196-ca2f-b905-a6ba-7721e8586ed7@huawei.com> <20240415101101.3dd207c4@kernel.org> <20240415111918.340ebb98@kernel.org> <20240415150136.337ada44@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 15 Apr 2024 16:57:54 -0700 Alexander Duyck wrote: > > The testing may be tricky. We could possibly test with hacking up the > > driver to use compound pages (say always allocate 16k) and making sure > > we don't refer to PAGE_SIZE directly in the test. > > > > BTW I have a spreadsheet of "promises", I'd be fine if we set a > > deadline for FBNIC to gain support for PAGE_SIZE != 4k and Kconfig > > to x86-only for now.. > > Why set a deadline? It doesn't make sense to add as a feature for now. Okay, maybe I'm trying to be too nice. Please have all the feedback addressed in v2.