From: Jakub Kicinski <kuba@kernel.org>
To: Danielle Ratson <danieller@nvidia.com>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>,
<edumazet@google.com>, <pabeni@redhat.com>, <corbet@lwn.net>,
<linux@armlinux.org.uk>, <sdf@google.com>,
<kory.maincent@bootlin.com>, <maxime.chevallier@bootlin.com>,
<vladimir.oltean@nxp.com>, <przemyslaw.kitszel@intel.com>,
<ahmed.zaki@intel.com>, <richardcochran@gmail.com>,
<shayagr@amazon.com>, <paul.greenwalt@intel.com>,
<jiri@resnulli.us>, <linux-doc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <mlxsw@nvidia.com>,
<petrm@nvidia.com>, <idosch@nvidia.com>
Subject: Re: [PATCH net-next v2 07/10] ethtool: cmis_cdb: Add a layer for supporting CDB commands
Date: Mon, 15 Apr 2024 21:29:27 -0700 [thread overview]
Message-ID: <20240415212927.2c87ddca@kernel.org> (raw)
In-Reply-To: <20240415120717.1251864-8-danieller@nvidia.com>
On Mon, 15 Apr 2024 15:07:14 +0300 Danielle Ratson wrote:
> + page_data->data = kmalloc(page_data->length, GFP_KERNEL);
> + if (!page_data->data)
> + return -ENOMEM;
> +
> + memcpy(page_data->data, data, page_data->length);
coccicheck suggests to use kmemdup() here:
net/ethtool/cmis_cdb.c:504:19-26: WARNING opportunity for kmemdup
--
pw-bot: cr
next prev parent reply other threads:[~2024-04-16 4:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 12:07 [PATCH net-next v2 00/10] Add ability to flash modules' firmware Danielle Ratson
2024-04-15 12:07 ` [PATCH net-next v2 01/10] ethtool: Add ethtool operation to write to a transceiver module EEPROM Danielle Ratson
2024-04-15 12:07 ` [PATCH net-next v2 02/10] mlxsw: Implement " Danielle Ratson
2024-04-15 12:07 ` [PATCH net-next v2 03/10] ethtool: Add an interface for flashing transceiver modules' firmware Danielle Ratson
2024-04-15 12:07 ` [PATCH net-next v2 04/10] ethtool: Add flashing transceiver modules' firmware notifications ability Danielle Ratson
2024-04-15 12:07 ` [PATCH net-next v2 05/10] include: netdevice: Add module firmware flashing in progress flag to net_device Danielle Ratson
2024-04-15 12:07 ` [PATCH net-next v2 06/10] net: sfp: Add more extended compliance codes Danielle Ratson
2024-04-15 12:07 ` [PATCH net-next v2 07/10] ethtool: cmis_cdb: Add a layer for supporting CDB commands Danielle Ratson
2024-04-16 4:29 ` Jakub Kicinski [this message]
2024-04-16 11:50 ` Danielle Ratson
2024-04-15 12:07 ` [PATCH net-next v2 08/10] ethtool: cmis_fw_update: add a layer for supporting firmware update using CDB Danielle Ratson
2024-04-15 12:07 ` [PATCH net-next v2 09/10] ethtool: Add ability to flash transceiver modules' firmware Danielle Ratson
2024-04-15 12:07 ` [PATCH net-next v2 10/10] ethtool: Veto some operations during firmware flashing process Danielle Ratson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240415212927.2c87ddca@kernel.org \
--to=kuba@kernel.org \
--cc=ahmed.zaki@intel.com \
--cc=corbet@lwn.net \
--cc=danieller@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=jiri@resnulli.us \
--cc=kory.maincent@bootlin.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paul.greenwalt@intel.com \
--cc=petrm@nvidia.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=richardcochran@gmail.com \
--cc=sdf@google.com \
--cc=shayagr@amazon.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).