From: Simon Horman <horms@kernel.org>
To: Petr Machata <petrm@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, Ido Schimmel <idosch@nvidia.com>,
mlxsw@nvidia.com, Tim 'mithro' Ansell <me@mith.ro>
Subject: Re: [PATCH net 3/3] mlxsw: pci: Fix driver initialization with old firmware
Date: Tue, 16 Apr 2024 15:33:24 +0100 [thread overview]
Message-ID: <20240416143324.GP2320920@kernel.org> (raw)
In-Reply-To: <449181a5ed544dd4790ae4d650586436848007cd.1713262810.git.petrm@nvidia.com>
On Tue, Apr 16, 2024 at 12:24:16PM +0200, Petr Machata wrote:
> From: Ido Schimmel <idosch@nvidia.com>
>
> The driver queries the Management Capabilities Mask (MCAM) register
> during initialization to understand if a new and deeper reset flow is
> supported.
>
> However, not all firmware versions support this register, leading to the
> driver failing to load.
>
> Fix by treating an error in the register query as an indication that the
> feature is not supported.
>
> Fixes: f257c73e5356 ("mlxsw: pci: Add support for new reset flow")
> Reported-by: Tim 'mithro' Ansell <me@mith.ro>
> Signed-off-by: Ido Schimmel <idosch@nvidia.com>
> Reviewed-by: Petr Machata <petrm@nvidia.com>
> Signed-off-by: Petr Machata <petrm@nvidia.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-04-16 14:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 10:24 [PATCH net 0/3] mlxsw: Fixes Petr Machata
2024-04-16 10:24 ` [PATCH net 1/3] mlxsw: core: Unregister EMAD trap using FORWARD action Petr Machata
2024-04-16 14:33 ` Simon Horman
2024-04-16 10:24 ` [PATCH net 2/3] mlxsw: core_env: Fix driver initialization with old firmware Petr Machata
2024-04-16 14:36 ` Simon Horman
2024-04-17 8:43 ` Ido Schimmel
2024-04-16 10:24 ` [PATCH net 3/3] mlxsw: pci: " Petr Machata
2024-04-16 14:33 ` Simon Horman [this message]
2024-04-17 4:18 ` Kalesh Anakkur Purayil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240416143324.GP2320920@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=me@mith.ro \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).