netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Jurgens <danielj@nvidia.com>
To: <netdev@vger.kernel.org>
Cc: <mst@redhat.com>, <jasowang@redhat.com>,
	<xuanzhuo@linux.alibaba.com>, <virtualization@lists.linux.dev>,
	<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
	<pabeni@redhat.com>, <jiri@nvidia.com>,
	Daniel Jurgens <danielj@nvidia.com>
Subject: [PATCH net-next v4 3/6] virtio_net: Add a lock for the command VQ.
Date: Tue, 16 Apr 2024 22:30:36 +0300	[thread overview]
Message-ID: <20240416193039.272997-4-danielj@nvidia.com> (raw)
In-Reply-To: <20240416193039.272997-1-danielj@nvidia.com>

The command VQ will no longer be protected by the RTNL lock. Use a
spinlock to protect the control buffer header and the VQ.

Signed-off-by: Daniel Jurgens <danielj@nvidia.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
---
 drivers/net/virtio_net.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 0ee192b45e1e..d02f83a919a7 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -282,6 +282,7 @@ struct virtnet_info {
 
 	/* Has control virtqueue */
 	bool has_cvq;
+	spinlock_t cvq_lock;
 
 	/* Host can handle any s/g split between our header and packet data */
 	bool any_header_sg;
@@ -2529,6 +2530,7 @@ static bool virtnet_send_command(struct virtnet_info *vi, u8 class, u8 cmd,
 	/* Caller should know better */
 	BUG_ON(!virtio_has_feature(vi->vdev, VIRTIO_NET_F_CTRL_VQ));
 
+	guard(spinlock)(&vi->cvq_lock);
 	vi->ctrl->status = ~0;
 	vi->ctrl->hdr.class = class;
 	vi->ctrl->hdr.cmd = cmd;
@@ -4818,8 +4820,10 @@ static int virtnet_probe(struct virtio_device *vdev)
 	    virtio_has_feature(vdev, VIRTIO_F_VERSION_1))
 		vi->any_header_sg = true;
 
-	if (virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_VQ))
+	if (virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_VQ)) {
 		vi->has_cvq = true;
+		spin_lock_init(&vi->cvq_lock);
+	}
 
 	if (virtio_has_feature(vdev, VIRTIO_NET_F_MTU)) {
 		mtu = virtio_cread16(vdev,
-- 
2.34.1


  parent reply	other threads:[~2024-04-16 19:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-16 19:30 [PATCH net-next v4 0/6] Remove RTNL lock protection of CVQ Daniel Jurgens
2024-04-16 19:30 ` [PATCH net-next v4 1/6] virtio_net: Store RSS setting in virtnet_info Daniel Jurgens
2024-04-16 19:30 ` [PATCH net-next v4 2/6] virtio_net: Remove command data from control_buf Daniel Jurgens
2024-04-16 19:30 ` Daniel Jurgens [this message]
2024-04-18  6:42   ` [PATCH net-next v4 3/6] virtio_net: Add a lock for the command VQ Jason Wang
2024-04-18  7:36     ` Heng Qi
2024-04-18 10:56       ` Paolo Abeni
2024-04-18 15:38         ` Dan Jurgens
2024-04-18 15:48           ` Paolo Abeni
2024-04-18 16:01             ` Jakub Kicinski
2024-04-18 16:12             ` Heng Qi
2024-04-19  0:28               ` Jason Wang
2024-04-18 16:06           ` Heng Qi
2024-04-16 19:30 ` [PATCH net-next v4 4/6] virtio_net: Do DIM update for specified queue only Daniel Jurgens
2024-04-16 19:30 ` [PATCH net-next v4 5/6] virtio_net: Add a lock for per queue RX coalesce Daniel Jurgens
2024-04-16 19:30 ` [PATCH net-next v4 6/6] virtio_net: Remove rtnl lock protection of command buffers Daniel Jurgens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240416193039.272997-4-danielj@nvidia.com \
    --to=danielj@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jasowang@redhat.com \
    --cc=jiri@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=virtualization@lists.linux.dev \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).