netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "jun.gu" <jun.gu@easystack.cn>
To: echaudro@redhat.com
Cc: dev@openvswitch.org, jun.gu@easystack.cn,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH net-next v3] net: openvswitch: Check vport net device name
Date: Wed, 17 Apr 2024 12:20:31 +0800	[thread overview]
Message-ID: <20240417042031.157008-1-jun.gu@easystack.cn> (raw)
In-Reply-To: <27644212-924C-4AB2-88F6-D209E2586E82@redhat.com>

Check vport net device name to ensure the provided name is not one of
its aliases. This can avoid that ovs userspace create and destroy vport
repeatedly.

Signed-off-by: Jun Gu <jun.gu@easystack.cn>
---
 net/openvswitch/vport-netdev.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/net/openvswitch/vport-netdev.c b/net/openvswitch/vport-netdev.c
index 903537a5da22..7003e76b8172 100644
--- a/net/openvswitch/vport-netdev.c
+++ b/net/openvswitch/vport-netdev.c
@@ -78,7 +78,10 @@ struct vport *ovs_netdev_link(struct vport *vport, const char *name)
 	int err;
 
 	vport->dev = dev_get_by_name(ovs_dp_get_net(vport->dp), name);
-	if (!vport->dev) {
+	/* Ensure that the device exists and that the provided
+	 * name is not one of its aliases.
+	 */
+	if ((!vport->dev) || strcmp(name, ovs_vport_name(vport))) {
 		err = -ENODEV;
 		goto error_free_vport;
 	}
-- 
2.25.1


  reply	other threads:[~2024-04-17  5:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-13  8:48 [PATCH] net: openvswitch: Check vport name jun.gu
2024-04-15 10:04 ` [ovs-dev] " Eelco Chaudron
     [not found]   ` <671d3c3b-a5c4-4dbd-800b-fbfec0fbe4dc@easystack.cn>
2024-04-16  8:04     ` Eelco Chaudron
2024-04-16  9:20       ` [PATCH v2] net: openvswitch: Check vport net device name jun.gu
2024-04-16 11:19         ` Eelco Chaudron
2024-04-17  4:20           ` jun.gu [this message]
2024-04-17 10:48             ` [PATCH net-next v3] " Eelco Chaudron
2024-04-18  2:32               ` [PATCH net-next v4] net: openvswitch: Check vport netdev name jun.gu
2024-04-18 15:38                 ` Jakub Kicinski
     [not found]                 ` <20240419043133.117295-1-jun.gu@easystack.cn>
2024-04-20  3:01                   ` Jakub Kicinski
2024-04-16 13:35 ` [PATCH] net: openvswitch: Check vport name Paolo Abeni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240417042031.157008-1-jun.gu@easystack.cn \
    --to=jun.gu@easystack.cn \
    --cc=dev@openvswitch.org \
    --cc=echaudro@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).