From: Jason Xing <kerneljasonxing@gmail.com>
To: edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
davem@davemloft.net, horms@kernel.org
Cc: netdev@vger.kernel.org, kerneljasonxing@gmail.com,
Jason Xing <kernelxing@tencent.com>
Subject: [PATCH net-next v2 3/3] net: rps: locklessly access rflow->cpu
Date: Wed, 17 Apr 2024 14:27:21 +0800 [thread overview]
Message-ID: <20240417062721.45652-4-kerneljasonxing@gmail.com> (raw)
In-Reply-To: <20240417062721.45652-1-kerneljasonxing@gmail.com>
From: Jason Xing <kernelxing@tencent.com>
This is the last member in struct rps_dev_flow which should be
protected locklessly. So finish it.
Signed-off-by: Jason Xing <kernelxing@tencent.com>
---
net/core/dev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index 40a535158e45..aeb45025e2bc 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -4533,7 +4533,7 @@ set_rps_cpu(struct net_device *dev, struct sk_buff *skb,
rps_input_queue_tail_save(&rflow->last_qtail, head);
}
- rflow->cpu = next_cpu;
+ WRITE_ONCE(rflow->cpu, next_cpu);
return rflow;
}
@@ -4597,7 +4597,7 @@ static int get_rps_cpu(struct net_device *dev, struct sk_buff *skb,
* we can look at the local (per receive queue) flow table
*/
rflow = &flow_table->flows[hash & flow_table->mask];
- tcpu = rflow->cpu;
+ tcpu = READ_ONCE(rflow->cpu);
/*
* If the desired CPU (where last recvmsg was done) is
--
2.37.3
next prev parent reply other threads:[~2024-04-17 6:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 6:27 [PATCH net-next v2 0/3] locklessly protect left members in struct rps_dev_flow Jason Xing
2024-04-17 6:27 ` [PATCH net-next v2 1/3] net: rps: protect last_qtail with rps_input_queue_tail_save() helper Jason Xing
2024-04-17 6:27 ` [PATCH net-next v2 2/3] net: rps: protect filter locklessly Jason Xing
2024-04-17 10:04 ` Eric Dumazet
2024-04-17 11:03 ` Jason Xing
2024-04-17 11:52 ` Eric Dumazet
2024-04-17 11:58 ` Eric Dumazet
2024-04-17 12:14 ` Jason Xing
2024-04-17 12:20 ` Jason Xing
2024-04-17 6:27 ` Jason Xing [this message]
2024-04-17 12:24 ` [PATCH net-next v2 3/3] net: rps: locklessly access rflow->cpu Jason Xing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240417062721.45652-4-kerneljasonxing@gmail.com \
--to=kerneljasonxing@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kernelxing@tencent.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).