From: Jakub Kicinski <kuba@kernel.org>
To: Justin Chen <justin.chen@broadcom.com>
Cc: Florian Fainelli <florian.fainelli@broadcom.com>,
Simon Horman <horms@kernel.org>,
Markus Elfring <Markus.Elfring@web.de>,
bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net] net: bcmasp: fix memory leak when bringing down if
Date: Wed, 17 Apr 2024 17:56:21 -0700 [thread overview]
Message-ID: <20240417175621.780cb1f8@kernel.org> (raw)
In-Reply-To: <1f3131a4-fa84-4d25-8c1a-ab0023aace23@broadcom.com>
On Wed, 17 Apr 2024 11:48:33 -0700 Justin Chen wrote:
> I try my best to address feedback. After a bit of thought, I feel the
> feedback given was not out of good faith. I would like to keep the patch
> as-is unless someone else has feedback. That is if the maintainers are
> ok with that.
TBH the "if" in the subject gives me pause too, please respin.
next prev parent reply other threads:[~2024-04-18 0:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 18:16 [PATCH net] net: bcmasp: fix memory leak when bringing down if Justin Chen
2024-04-12 21:09 ` Florian Fainelli
2024-04-14 11:23 ` Markus Elfring
2024-04-15 17:36 ` Justin Chen
2024-04-15 19:46 ` Markus Elfring
2024-04-17 16:19 ` Simon Horman
2024-04-17 16:52 ` Florian Fainelli
2024-04-17 18:48 ` Justin Chen
2024-04-18 0:56 ` Jakub Kicinski [this message]
2024-04-17 20:34 ` Simon Horman
2024-04-18 8:02 ` net: bcmasp: Patch review challenges Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240417175621.780cb1f8@kernel.org \
--to=kuba@kernel.org \
--cc=Markus.Elfring@web.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=horms@kernel.org \
--cc=justin.chen@broadcom.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).