From: Simon Horman <horms@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Jamal Hadi Salim" <jhs@mojatatu.com>,
"Toke Høiland-Jørgensen" <toke@redhat.com>,
"Cong Wang" <xiyou.wangcong@gmail.com>,
"Jiri Pirko" <jiri@resnulli.us>,
netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH v2 net-next 11/14] net_sched: sch_hfsc: implement lockless accesses to q->defcls
Date: Thu, 18 Apr 2024 16:04:44 +0100 [thread overview]
Message-ID: <20240418150444.GF3975545@kernel.org> (raw)
In-Reply-To: <20240418073248.2952954-12-edumazet@google.com>
On Thu, Apr 18, 2024 at 07:32:45AM +0000, Eric Dumazet wrote:
> Instead of relying on RTNL, hfsc_dump_qdisc() can use READ_ONCE()
> annotation, paired with WRITE_ONCE() one in hfsc_change_qdisc().
>
> Use READ_ONCE(q->defcls) in hfsc_classify() to
> no longer acquire qdisc lock from hfsc_change_qdisc().
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-04-18 15:04 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 7:32 [PATCH v2 net-next 00/14] net_sched: first series for RTNL-less qdisc dumps Eric Dumazet
2024-04-18 7:32 ` [PATCH v2 net-next 01/14] net_sched: sch_fq: implement lockless fq_dump() Eric Dumazet
2024-04-18 13:55 ` Simon Horman
2024-04-18 7:32 ` [PATCH v2 net-next 02/14] net_sched: cake: implement lockless cake_dump() Eric Dumazet
2024-04-18 13:57 ` Simon Horman
2024-04-18 15:20 ` Toke Høiland-Jørgensen
2024-04-18 7:32 ` [PATCH v2 net-next 03/14] net_sched: sch_cbs: implement lockless cbs_dump() Eric Dumazet
2024-04-18 7:32 ` [PATCH v2 net-next 04/14] net_sched: sch_choke: implement lockless choke_dump() Eric Dumazet
2024-04-18 13:58 ` Simon Horman
2024-04-18 7:32 ` [PATCH v2 net-next 05/14] net_sched: sch_codel: implement lockless codel_dump() Eric Dumazet
2024-04-18 7:32 ` [PATCH v2 net-next 06/14] net_sched: sch_tfs: implement lockless etf_dump() Eric Dumazet
2024-04-18 7:32 ` [PATCH v2 net-next 07/14] net_sched: sch_ets: implement lockless ets_dump() Eric Dumazet
2024-04-18 7:32 ` [PATCH v2 net-next 08/14] net_sched: sch_fifo: implement lockless __fifo_dump() Eric Dumazet
2024-04-18 15:04 ` Simon Horman
2024-04-18 7:32 ` [PATCH v2 net-next 09/14] net_sched: sch_fq_codel: implement lockless fq_codel_dump() Eric Dumazet
2024-04-18 7:32 ` [PATCH v2 net-next 10/14] net_sched: sch_fq_pie: implement lockless fq_pie_dump() Eric Dumazet
2024-04-18 7:32 ` [PATCH v2 net-next 11/14] net_sched: sch_hfsc: implement lockless accesses to q->defcls Eric Dumazet
2024-04-18 15:04 ` Simon Horman [this message]
2024-04-18 7:32 ` [PATCH v2 net-next 12/14] net_sched: sch_hhf: implement lockless hhf_dump() Eric Dumazet
2024-04-18 7:32 ` [PATCH v2 net-next 13/14] net_sched: sch_pie: implement lockless pie_dump() Eric Dumazet
2024-04-18 7:32 ` [PATCH v2 net-next 14/14] net_sched: sch_skbprio: implement lockless skbprio_dump() Eric Dumazet
2024-04-18 15:04 ` Simon Horman
2024-04-18 10:23 ` [PATCH v2 net-next 00/14] net_sched: first series for RTNL-less qdisc dumps Jamal Hadi Salim
2024-04-18 15:08 ` tdc [Was: Re: [PATCH v2 net-next 00/14] net_sched: first series for RTNL-less] " Simon Horman
2024-04-18 23:05 ` Jamal Hadi Salim
2024-04-19 7:18 ` Simon Horman
2024-04-19 14:24 ` Jamal Hadi Salim
2024-04-22 18:34 ` Simon Horman
2024-04-19 10:40 ` [PATCH v2 net-next 00/14] net_sched: first series for RTNL-less " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240418150444.GF3975545@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=toke@redhat.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).