From: Jakub Kicinski <kuba@kernel.org>
To: Mahesh Bandewar <maheshb@google.com>
Cc: Netdev <netdev@vger.kernel.org>,
Linux <linux-kernel@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Richard Cochran <richardcochran@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Sagi Maimon <maimon.sagi@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
John Stultz <jstultz@google.com>,
Mahesh Bandewar <mahesh@bandewar.net>
Subject: Re: [PATCHv2 next] ptp: update gettimex64 to provide ts optionally in mono-raw base.
Date: Thu, 18 Apr 2024 18:55:24 -0700 [thread overview]
Message-ID: <20240418185524.18801983@kernel.org> (raw)
In-Reply-To: <20240418042706.1261473-1-maheshb@google.com>
On Wed, 17 Apr 2024 21:27:06 -0700 Mahesh Bandewar wrote:
> --- a/include/uapi/linux/ptp_clock.h
> +++ b/include/uapi/linux/ptp_clock.h
> @@ -157,7 +157,12 @@ struct ptp_sys_offset {
>
> struct ptp_sys_offset_extended {
> unsigned int n_samples; /* Desired number of measurements. */
> - unsigned int rsv[3]; /* Reserved for future use. */
> + /* The original implementation provided timestamps (always) in
> + * REALTIME clock-base. Since CLOCK_REALTIME is 0, adding
> + * clockid doesn't break backward compatibility.
> + */
> + clockid_t clockid; /* One of the supported clock-ids */
> + unsigned int rsv[2]; /* Reserved for future use. */
This suffers from a moderate inability to build:
usr/include/linux/ptp_clock.h:164:2: error: unknown type name 'clockid_t'
164 | clockid_t clockid; /* One of the supported clock-ids */
| ^
--
pw-bot: cr
next prev parent reply other threads:[~2024-04-19 1:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 4:27 [PATCHv2 next] ptp: update gettimex64 to provide ts optionally in mono-raw base Mahesh Bandewar
2024-04-19 1:55 ` Jakub Kicinski [this message]
2024-04-19 22:14 ` Mahesh Bandewar (महेश बंडेवार)
2024-04-19 4:56 ` Thomas Gleixner
2024-04-19 22:32 ` Mahesh Bandewar (महेश बंडेवार)
2024-04-21 18:27 ` David Laight
2024-04-22 22:04 ` Mahesh Bandewar (महेश बंडेवार)
2024-04-23 0:24 ` Thomas Gleixner
2024-04-23 9:22 ` David Laight
2024-04-23 13:22 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240418185524.18801983@kernel.org \
--to=kuba@kernel.org \
--cc=arnd@arndb.de \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jstultz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mahesh@bandewar.net \
--cc=maheshb@google.com \
--cc=maimon.sagi@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).