From: Simon Horman <horms@kernel.org>
To: Jiawen Wu <jiawenwu@trustnetic.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, rmk+kernel@armlinux.org.uk, andrew@lunn.ch,
netdev@vger.kernel.org, mengyuanlou@net-swift.com,
duanqiangwen@net-swift.com
Subject: Re: [PATCH net 4/5] net: wangxun: change NETIF_F_HW_VLAN_STAG_* to fixed features
Date: Thu, 18 Apr 2024 19:58:51 +0100 [thread overview]
Message-ID: <20240418185851.GQ3975545@kernel.org> (raw)
In-Reply-To: <20240416062952.14196-5-jiawenwu@trustnetic.com>
On Tue, Apr 16, 2024 at 02:29:51PM +0800, Jiawen Wu wrote:
> Because the hardware doesn't support the configuration of VLAN STAG,
> remove NETIF_F_HW_VLAN_STAG_* in netdev->features, and set their state
> to be consistent with NETIF_F_HW_VLAN_CTAG_*.
>
> Fixes: 6670f1ece2c8 ("net: txgbe: Add netdev features support")
> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
Hi Jiawen Wu,
I am having trouble reconciling "hardware doesn't support the configuration
of VLAN STAG" with both "set their state to be consistent with
NETIF_F_HW_VLAN_CTAG_*" and the code changes.
Is the problem here not that VLAN STAGs aren't supported by
the HW, but rather that the HW requires that corresponding
CTAG and STAG configuration always matches?
I.e, the HW requires:
f & NETIF_F_HW_VLAN_CTAG_FILTER == f & NETIF_F_HW_VLAN_STAG_FILTER
f & NETIF_F_HW_VLAN_CTAG_RX == f & NETIF_F_HW_VLAN_STAG_RX
f & NETIF_F_HW_VLAN_CTAG_TX == f & NETIF_F_HW_VLAN_STAG_TX
If so, I wonder if only the wx_fix_features() portion of
this patch is required.
...
next prev parent reply other threads:[~2024-04-18 18:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 6:29 [PATCH net 0/5] Wangxun fixes Jiawen Wu
2024-04-16 6:29 ` [PATCH net 1/5] net: wangxun: fix the incorrect display of queue number in statistics Jiawen Wu
2024-04-16 10:16 ` Francois Romieu
2024-04-16 6:29 ` [PATCH net 2/5] net: wangxun: fix error statistics when the device is reset Jiawen Wu
2024-04-16 10:17 ` Francois Romieu
2024-04-16 14:56 ` Andrew Lunn
2024-04-24 7:53 ` Jiawen Wu
2024-04-16 6:29 ` [PATCH net 3/5] net: wangxun: fix to change Rx features Jiawen Wu
2024-04-16 15:01 ` Andrew Lunn
2024-04-16 6:29 ` [PATCH net 4/5] net: wangxun: change NETIF_F_HW_VLAN_STAG_* to fixed features Jiawen Wu
2024-04-18 18:58 ` Simon Horman [this message]
2024-04-25 6:53 ` Jiawen Wu
2024-04-26 7:07 ` Simon Horman
2024-04-16 6:29 ` [PATCH net 5/5] net: txgbe: fix to control VLAN strip Jiawen Wu
2024-04-18 19:54 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240418185851.GQ3975545@kernel.org \
--to=horms@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=duanqiangwen@net-swift.com \
--cc=edumazet@google.com \
--cc=jiawenwu@trustnetic.com \
--cc=kuba@kernel.org \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).