From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, David Ahern <dsahern@kernel.org>,
eric.dumazet@gmail.com,
Andreas Roeseler <andreas.a.roeseler@gmail.com>
Subject: Re: [PATCH net] icmp: prevent possible NULL dereferences from icmp_build_probe()
Date: Fri, 19 Apr 2024 06:45:52 -0700 [thread overview]
Message-ID: <20240419064552.5dbe33e6@kernel.org> (raw)
In-Reply-To: <20240419105332.2430179-1-edumazet@google.com>
On Fri, 19 Apr 2024 10:53:32 +0000 Eric Dumazet wrote:
> + in6_dev = __in6_dev_get(dev);
> + if (in6_dev && !list_empty(&in6_dev->addr_list))
There's got to be some conditional include somewhere because this seems
to break cut-down builds (presumably IPv6=n):
net/ipv4/icmp.c: In function ‘icmp_build_probe’:
net/ipv4/icmp.c:1125:19: error: implicit declaration of function ‘__in6_dev_get’; did you mean ‘in_dev_get’? [-Werror=implicit-function-declaration]
1125 | in6_dev = __in6_dev_get(dev);
| ^~~~~~~~~~~~~
| in_dev_get
net/ipv4/icmp.c:1125:17: error: assignment to ‘struct inet6_dev *’ from ‘int’ makes pointer from integer without a cast [-Werror=int-conversion]
1125 | in6_dev = __in6_dev_get(dev);
| ^
--
pw-bot: cr
next prev parent reply other threads:[~2024-04-19 13:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 10:53 [PATCH net] icmp: prevent possible NULL dereferences from icmp_build_probe() Eric Dumazet
2024-04-19 13:45 ` Jakub Kicinski [this message]
2024-04-19 13:51 ` Eric Dumazet
2024-04-19 14:03 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240419064552.5dbe33e6@kernel.org \
--to=kuba@kernel.org \
--cc=andreas.a.roeseler@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).