From: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
To: virtualization@lists.linux.dev
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org
Subject: [PATCH vhost v1 7/7] virtio_net: remove the misleading comment
Date: Mon, 22 Apr 2024 09:54:03 +0800 [thread overview]
Message-ID: <20240422015403.72526-8-xuanzhuo@linux.alibaba.com> (raw)
In-Reply-To: <20240422015403.72526-1-xuanzhuo@linux.alibaba.com>
We call the build_skb() actually without copying data.
The comment is misleading. So remove it.
Signed-off-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
---
drivers/net/virtio_net.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index eff8f16a9fe0..a8dac48a1be7 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -690,7 +690,6 @@ static struct sk_buff *page_to_skb(struct virtnet_info *vi,
shinfo_size = SKB_DATA_ALIGN(sizeof(struct skb_shared_info));
- /* copy small packet so we can reuse these pages */
if (!NET_IP_ALIGN && len > GOOD_COPY_LEN && tailroom >= shinfo_size) {
skb = virtnet_build_skb(buf, truesize, p - buf, len);
if (unlikely(!skb))
--
2.32.0.3.g01195cf9f
prev parent reply other threads:[~2024-04-22 1:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 1:53 [PATCH vhost v1 0/7] virtio_net: rx enable premapped mode by default Xuan Zhuo
2024-04-22 1:53 ` [PATCH vhost v1 1/7] virtio_ring: introduce dma map api for page Xuan Zhuo
2024-04-22 1:53 ` [PATCH vhost v1 2/7] virtio_ring: enable premapped mode whatever use_dma_api Xuan Zhuo
2024-04-22 1:53 ` [PATCH vhost v1 3/7] virtio_net: replace private by pp struct inside page Xuan Zhuo
2024-04-22 1:54 ` [PATCH vhost v1 4/7] virtio_net: big mode support premapped Xuan Zhuo
2024-04-22 5:40 ` kernel test robot
2024-04-22 1:54 ` [PATCH vhost v1 5/7] virtio_net: enable premapped by default Xuan Zhuo
2024-04-22 1:54 ` [PATCH vhost v1 6/7] virtio_net: rx remove premapped failover code Xuan Zhuo
2024-04-22 1:54 ` Xuan Zhuo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240422015403.72526-8-xuanzhuo@linux.alibaba.com \
--to=xuanzhuo@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).