From: Jakub Kicinski <kuba@kernel.org>
To: David Ahern <dsahern@kernel.org>
Cc: Eric Dumazet <edumazet@google.com>,
davem@davemloft.net, netdev@vger.kernel.org, pabeni@redhat.com,
shuah@kernel.org, sdf@google.com, amritha.nambiar@intel.com,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next 1/4] netdev: support dumping a single netdev in qstats
Date: Mon, 22 Apr 2024 06:48:25 -0700 [thread overview]
Message-ID: <20240422064825.18850cc3@kernel.org> (raw)
In-Reply-To: <a1340c70-bbc9-4b23-8e9a-1bc401132721@kernel.org>
On Sun, 21 Apr 2024 13:32:24 -0600 David Ahern wrote:
> On 4/21/24 1:17 PM, Eric Dumazet wrote:
> > I wonder if NLM_F_DUMP_FILTERED should not be reported to user space ?
>
> good point. We do set that flag for other dumps when a filter has been
> used to limit data returned.
That flag appears to be a, hm, historic workaround?
If I was to guess what the motivation was I'd say that it's because
"old school netlink" didn't reject unknown attributes. And you wanted
to know whether the kernel did the filtering or you have to filter
again in user space? Am I close? :)
The flag is mostly used in the IP stack, I'd rather try to deprecate
it than propagate it to new genetlink families which do full input
validation, rendering the flag 100% unnecessary.
next prev parent reply other threads:[~2024-04-22 13:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-20 2:35 [PATCH net-next 0/4] netdev: support dumping a single netdev in qstats Jakub Kicinski
2024-04-20 2:35 ` [PATCH net-next 1/4] " Jakub Kicinski
2024-04-21 0:58 ` David Ahern
2024-04-21 19:17 ` Eric Dumazet
2024-04-21 19:32 ` David Ahern
2024-04-22 13:48 ` Jakub Kicinski [this message]
2024-04-22 15:02 ` Eric Dumazet
2024-04-22 15:23 ` David Ahern
2024-04-20 2:35 ` [PATCH net-next 2/4] netlink: move extack writing helpers Jakub Kicinski
2024-04-21 0:59 ` David Ahern
2024-04-20 2:35 ` [PATCH net-next 3/4] netlink: support all extack types in dumps Jakub Kicinski
2024-04-21 1:00 ` David Ahern
2024-04-20 2:35 ` [PATCH net-next 4/4] selftests: drv-net: test dumping qstats per device Jakub Kicinski
2024-04-23 17:20 ` [PATCH net-next 0/4] netdev: support dumping a single netdev in qstats patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240422064825.18850cc3@kernel.org \
--to=kuba@kernel.org \
--cc=amritha.nambiar@intel.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@google.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).