From: Simon Horman <horms@kernel.org>
To: Daniel Machon <daniel.machon@microchip.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Bryan Whitehead <bryan.whitehead@microchip.com>,
Richard Cochran <richardcochran@gmail.com>,
Horatiu Vultur <horatiu.vultur@microchip.com>,
Lars Povlsen <lars.povlsen@microchip.com>,
Steen Hegelund <Steen.Hegelund@microchip.com>,
UNGLinuxDriver@microchip.com, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next 4/4] net: sparx5: Correct spelling in comments
Date: Mon, 22 Apr 2024 11:57:56 +0100 [thread overview]
Message-ID: <20240422105756.GC42092@kernel.org> (raw)
In-Reply-To: <20240420192424.42z2aztt73grdvsj@DEN-DL-M70577>
On Sat, Apr 20, 2024 at 07:24:24PM +0000, Daniel Machon wrote:
> Hi Simon,
>
> > -/* Convert validation error code into tc extact error message */
> > +/* Convert validation error code into tc exact error message */
>
> This seems wrong. I bet it refers to the 'netlink_ext_ack' struct. So
> the fix should be 'extack' instead.
>
> > void vcap_set_tc_exterr(struct flow_cls_offload *fco, struct vcap_rule *vrule)
> > {
> > switch (vrule->exterr) {
> > diff --git a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h
> > index 56874f2adbba..d6c3e90745a7 100644
> > --- a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h
> > +++ b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h
> > @@ -238,7 +238,7 @@ const struct vcap_set *vcap_keyfieldset(struct vcap_control *vctrl,
> > /* Copy to host byte order */
> > void vcap_netbytes_copy(u8 *dst, u8 *src, int count);
> >
> > -/* Convert validation error code into tc extact error message */
> > +/* Convert validation error code into tc exact error message */
>
> Same here.
Thanks Daniel,
Silly me. I'll drop these changes in v2.
> > void vcap_set_tc_exterr(struct flow_cls_offload *fco, struct vcap_rule *vrule);
>
> The other fixes seems correct.
>
> /Daniel
>
next prev parent reply other threads:[~2024-04-22 10:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 13:54 [PATCH net-next 0/4] net: microchip: Correct spelling in comments Simon Horman
2024-04-19 13:54 ` [PATCH net-next 1/4] net: lan743x: " Simon Horman
2024-04-19 13:54 ` [PATCH net-next 2/4] net: lan966x: " Simon Horman
2024-04-19 13:54 ` [PATCH net-next 3/4] net: encx24j600: " Simon Horman
2024-04-19 13:54 ` [PATCH net-next 4/4] net: sparx5: " Simon Horman
2024-04-20 19:24 ` Daniel Machon
2024-04-22 10:57 ` Simon Horman [this message]
2024-04-23 11:29 ` Daniel Machon
2024-04-23 13:54 ` Simon Horman
2024-04-23 16:18 ` Simon Horman
2024-04-23 19:29 ` Daniel Machon
2024-04-24 14:59 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240422105756.GC42092@kernel.org \
--to=horms@kernel.org \
--cc=Steen.Hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=bryan.whitehead@microchip.com \
--cc=daniel.machon@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horatiu.vultur@microchip.com \
--cc=kuba@kernel.org \
--cc=lars.povlsen@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).