From: Jakub Kicinski <kuba@kernel.org>
To: Jun Gu <jun.gu@easystack.cn>
Cc: dev@openvswitch.org, echaudro@redhat.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v4] net: openvswitch: Check vport netdev name
Date: Mon, 22 Apr 2024 17:38:50 -0700 [thread overview]
Message-ID: <20240422173850.2222305f@kernel.org> (raw)
In-Reply-To: <20240419061425.132723-1-jun.gu@easystack.cn>
On Fri, 19 Apr 2024 14:14:25 +0800 Jun Gu wrote:
> vport->dev = dev_get_by_name(ovs_dp_get_net(vport->dp), name);
> - if (!vport->dev) {
> + /* Ensure that the device exists and that the provided
> + * name is not one of its aliases.
> + */
> + if (!vport->dev || strcmp(name, ovs_vport_name(vport))) {
> err = -ENODEV;
> goto error_free_vport;
> }
Sorry I applied this before I realised that it's buggy.
dev_get_by_name() will give you a reference on the device.
You must free it, so the error handling is different.
Please follow up ASAP to fix that.
next prev parent reply other threads:[~2024-04-23 0:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 6:14 [PATCH net-next v4] net: openvswitch: Check vport netdev name Jun Gu
2024-04-23 0:38 ` Jakub Kicinski [this message]
2024-04-23 2:34 ` Jun Gu
2024-04-23 0:53 ` patchwork-bot+netdevbpf
-- strict thread matches above, loose matches on Subject: below --
2024-04-17 10:48 [PATCH net-next v3] net: openvswitch: Check vport net device name Eelco Chaudron
2024-04-18 2:32 ` [PATCH net-next v4] net: openvswitch: Check vport netdev name jun.gu
2024-04-18 15:38 ` Jakub Kicinski
[not found] ` <20240419043133.117295-1-jun.gu@easystack.cn>
2024-04-20 3:01 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240422173850.2222305f@kernel.org \
--to=kuba@kernel.org \
--cc=dev@openvswitch.org \
--cc=echaudro@redhat.com \
--cc=jun.gu@easystack.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).