* [PATCH net-next 1/4] net: lan743x: Correct spelling in comments
2024-04-19 13:54 [PATCH net-next 0/4] net: microchip: Correct spelling in comments Simon Horman
@ 2024-04-19 13:54 ` Simon Horman
2024-04-19 13:54 ` [PATCH net-next 2/4] net: lan966x: " Simon Horman
` (2 subsequent siblings)
3 siblings, 0 replies; 12+ messages in thread
From: Simon Horman @ 2024-04-19 13:54 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
Cc: Bryan Whitehead, Richard Cochran, Horatiu Vultur, Lars Povlsen,
Steen Hegelund, Daniel Machon, UNGLinuxDriver, netdev,
linux-arm-kernel
Correct spelling in comments, as flagged by codespell.
Signed-off-by: Simon Horman <horms@kernel.org>
---
drivers/net/ethernet/microchip/lan743x_main.c | 4 ++--
drivers/net/ethernet/microchip/lan743x_ptp.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/microchip/lan743x_main.c b/drivers/net/ethernet/microchip/lan743x_main.c
index d37a49cd5c69..cee47729d022 100644
--- a/drivers/net/ethernet/microchip/lan743x_main.c
+++ b/drivers/net/ethernet/microchip/lan743x_main.c
@@ -803,7 +803,7 @@ static int lan743x_mdiobus_read_c22(struct mii_bus *bus, int phy_id, int index)
u32 val, mii_access;
int ret;
- /* comfirm MII not busy */
+ /* confirm MII not busy */
ret = lan743x_mac_mii_wait_till_not_busy(adapter);
if (ret < 0)
return ret;
@@ -868,7 +868,7 @@ static int lan743x_mdiobus_read_c45(struct mii_bus *bus, int phy_id,
u32 mmd_access;
int ret;
- /* comfirm MII not busy */
+ /* confirm MII not busy */
ret = lan743x_mac_mii_wait_till_not_busy(adapter);
if (ret < 0)
return ret;
diff --git a/drivers/net/ethernet/microchip/lan743x_ptp.c b/drivers/net/ethernet/microchip/lan743x_ptp.c
index 2801f08bf1c9..80d9680b3830 100644
--- a/drivers/net/ethernet/microchip/lan743x_ptp.c
+++ b/drivers/net/ethernet/microchip/lan743x_ptp.c
@@ -555,7 +555,7 @@ static int lan743x_ptp_perout(struct lan743x_adapter *adapter, int on,
if (half == wf_high) {
/* It's 50% match. Use the toggle option */
pulse_width = PTP_GENERAL_CONFIG_CLOCK_EVENT_TOGGLE_;
- /* In this case, devide period value by 2 */
+ /* In this case, divide period value by 2 */
ts_period = ns_to_timespec64(div_s64(period64, 2));
period_sec = ts_period.tv_sec;
period_nsec = ts_period.tv_nsec;
--
2.43.0
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH net-next 2/4] net: lan966x: Correct spelling in comments
2024-04-19 13:54 [PATCH net-next 0/4] net: microchip: Correct spelling in comments Simon Horman
2024-04-19 13:54 ` [PATCH net-next 1/4] net: lan743x: " Simon Horman
@ 2024-04-19 13:54 ` Simon Horman
2024-04-19 13:54 ` [PATCH net-next 3/4] net: encx24j600: " Simon Horman
2024-04-19 13:54 ` [PATCH net-next 4/4] net: sparx5: " Simon Horman
3 siblings, 0 replies; 12+ messages in thread
From: Simon Horman @ 2024-04-19 13:54 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
Cc: Bryan Whitehead, Richard Cochran, Horatiu Vultur, Lars Povlsen,
Steen Hegelund, Daniel Machon, UNGLinuxDriver, netdev,
linux-arm-kernel
Correct spelling in comments, as flagged by codespell.
Signed-off-by: Simon Horman <horms@kernel.org>
---
drivers/net/ethernet/microchip/lan966x/lan966x_ifh.h | 2 +-
drivers/net/ethernet/microchip/lan966x/lan966x_main.c | 4 ++--
drivers/net/ethernet/microchip/lan966x/lan966x_main.h | 2 +-
drivers/net/ethernet/microchip/lan966x/lan966x_port.c | 2 +-
drivers/net/ethernet/microchip/lan966x/lan966x_vlan.c | 2 +-
5 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/microchip/lan966x/lan966x_ifh.h b/drivers/net/ethernet/microchip/lan966x/lan966x_ifh.h
index f3b1e0d31826..e706163ce9cc 100644
--- a/drivers/net/ethernet/microchip/lan966x/lan966x_ifh.h
+++ b/drivers/net/ethernet/microchip/lan966x/lan966x_ifh.h
@@ -78,7 +78,7 @@
/* Classified internal priority for queuing */
#define IFH_POS_QOS_CLASS 100
-/* Bit mask with eight cpu copy classses */
+/* Bit mask with eight cpu copy classes */
#define IFH_POS_CPUQ 92
/* Relearn + learn flags (*) */
diff --git a/drivers/net/ethernet/microchip/lan966x/lan966x_main.c b/drivers/net/ethernet/microchip/lan966x/lan966x_main.c
index 2635ef8958c8..b7e75da65834 100644
--- a/drivers/net/ethernet/microchip/lan966x/lan966x_main.c
+++ b/drivers/net/ethernet/microchip/lan966x/lan966x_main.c
@@ -276,7 +276,7 @@ static int lan966x_port_ifh_xmit(struct sk_buff *skb,
++i;
}
- /* Inidcate EOF and valid bytes in the last word */
+ /* Indicate EOF and valid bytes in the last word */
lan_wr(QS_INJ_CTRL_GAP_SIZE_SET(1) |
QS_INJ_CTRL_VLD_BYTES_SET(skb->len < LAN966X_BUFFER_MIN_SZ ?
0 : last) |
@@ -520,7 +520,7 @@ bool lan966x_hw_offload(struct lan966x *lan966x, u32 port, struct sk_buff *skb)
u32 val;
/* The IGMP and MLD frames are not forward by the HW if
- * multicast snooping is enabled, therefor don't mark as
+ * multicast snooping is enabled, therefore don't mark as
* offload to allow the SW to forward the frames accordingly.
*/
val = lan_rd(lan966x, ANA_CPU_FWD_CFG(port));
diff --git a/drivers/net/ethernet/microchip/lan966x/lan966x_main.h b/drivers/net/ethernet/microchip/lan966x/lan966x_main.h
index caa9e0533c96..f8bebbcf77b2 100644
--- a/drivers/net/ethernet/microchip/lan966x/lan966x_main.h
+++ b/drivers/net/ethernet/microchip/lan966x/lan966x_main.h
@@ -326,7 +326,7 @@ struct lan966x {
u8 base_mac[ETH_ALEN];
- spinlock_t tx_lock; /* lock for frame transmition */
+ spinlock_t tx_lock; /* lock for frame transmission */
struct net_device *bridge;
u16 bridge_mask;
diff --git a/drivers/net/ethernet/microchip/lan966x/lan966x_port.c b/drivers/net/ethernet/microchip/lan966x/lan966x_port.c
index 2e83bbb9477e..fdfa4040d9ee 100644
--- a/drivers/net/ethernet/microchip/lan966x/lan966x_port.c
+++ b/drivers/net/ethernet/microchip/lan966x/lan966x_port.c
@@ -88,7 +88,7 @@ static void lan966x_port_link_down(struct lan966x_port *port)
SYS_FRONT_PORT_MODE_HDX_MODE,
lan966x, SYS_FRONT_PORT_MODE(port->chip_port));
- /* 8: Flush the queues accociated with the port */
+ /* 8: Flush the queues associated with the port */
lan_rmw(QSYS_SW_PORT_MODE_AGING_MODE_SET(3),
QSYS_SW_PORT_MODE_AGING_MODE,
lan966x, QSYS_SW_PORT_MODE(port->chip_port));
diff --git a/drivers/net/ethernet/microchip/lan966x/lan966x_vlan.c b/drivers/net/ethernet/microchip/lan966x/lan966x_vlan.c
index 3c44660128da..fa34a739c748 100644
--- a/drivers/net/ethernet/microchip/lan966x/lan966x_vlan.c
+++ b/drivers/net/ethernet/microchip/lan966x/lan966x_vlan.c
@@ -157,7 +157,7 @@ void lan966x_vlan_port_apply(struct lan966x_port *port)
pvid = lan966x_vlan_port_get_pvid(port);
- /* Ingress clasification (ANA_PORT_VLAN_CFG) */
+ /* Ingress classification (ANA_PORT_VLAN_CFG) */
/* Default vlan to classify for untagged frames (may be zero) */
val = ANA_VLAN_CFG_VLAN_VID_SET(pvid);
if (port->vlan_aware)
--
2.43.0
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH net-next 3/4] net: encx24j600: Correct spelling in comments
2024-04-19 13:54 [PATCH net-next 0/4] net: microchip: Correct spelling in comments Simon Horman
2024-04-19 13:54 ` [PATCH net-next 1/4] net: lan743x: " Simon Horman
2024-04-19 13:54 ` [PATCH net-next 2/4] net: lan966x: " Simon Horman
@ 2024-04-19 13:54 ` Simon Horman
2024-04-19 13:54 ` [PATCH net-next 4/4] net: sparx5: " Simon Horman
3 siblings, 0 replies; 12+ messages in thread
From: Simon Horman @ 2024-04-19 13:54 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
Cc: Bryan Whitehead, Richard Cochran, Horatiu Vultur, Lars Povlsen,
Steen Hegelund, Daniel Machon, UNGLinuxDriver, netdev,
linux-arm-kernel
Correct spelling in comments, as flagged by codespell.
Signed-off-by: Simon Horman <horms@kernel.org>
---
drivers/net/ethernet/microchip/encx24j600-regmap.c | 4 ++--
drivers/net/ethernet/microchip/encx24j600.c | 6 ++++--
drivers/net/ethernet/microchip/encx24j600_hw.h | 2 +-
3 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/microchip/encx24j600-regmap.c b/drivers/net/ethernet/microchip/encx24j600-regmap.c
index 443128adbcb6..3885d6fbace1 100644
--- a/drivers/net/ethernet/microchip/encx24j600-regmap.c
+++ b/drivers/net/ethernet/microchip/encx24j600-regmap.c
@@ -75,7 +75,7 @@ static int regmap_encx24j600_sfr_read(void *context, u8 reg, u8 *val,
if (unlikely(ret))
return ret;
} else {
- /* Translate registers that are more effecient using
+ /* Translate registers that are more efficient using
* 3-byte SPI commands
*/
switch (reg) {
@@ -129,7 +129,7 @@ static int regmap_encx24j600_sfr_update(struct encx24j600_context *ctx,
if (unlikely(ret))
return ret;
} else {
- /* Translate registers that are more effecient using
+ /* Translate registers that are more efficient using
* 3-byte SPI commands
*/
switch (reg) {
diff --git a/drivers/net/ethernet/microchip/encx24j600.c b/drivers/net/ethernet/microchip/encx24j600.c
index cdc2872ace1b..b011bf5c2305 100644
--- a/drivers/net/ethernet/microchip/encx24j600.c
+++ b/drivers/net/ethernet/microchip/encx24j600.c
@@ -569,7 +569,7 @@ static void encx24j600_dump_config(struct encx24j600_priv *priv,
pr_info(DRV_NAME " MABBIPG: %04X\n", encx24j600_read_reg(priv,
MABBIPG));
- /* PHY configuation */
+ /* PHY configuration */
pr_info(DRV_NAME " PHCON1: %04X\n", encx24j600_read_phy(priv, PHCON1));
pr_info(DRV_NAME " PHCON2: %04X\n", encx24j600_read_phy(priv, PHCON2));
pr_info(DRV_NAME " PHANA: %04X\n", encx24j600_read_phy(priv, PHANA));
@@ -837,7 +837,9 @@ static void encx24j600_hw_tx(struct encx24j600_priv *priv)
dump_packet("TX", priv->tx_skb->len, priv->tx_skb->data);
if (encx24j600_read_reg(priv, EIR) & TXABTIF)
- /* Last transmition aborted due to error. Reset TX interface */
+ /* Last transmission aborted due to error.
+ * Reset TX interface
+ */
encx24j600_reset_hw_tx(priv);
/* Clear the TXIF flag if were previously set */
diff --git a/drivers/net/ethernet/microchip/encx24j600_hw.h b/drivers/net/ethernet/microchip/encx24j600_hw.h
index 34c5a289898c..2522f4f48b67 100644
--- a/drivers/net/ethernet/microchip/encx24j600_hw.h
+++ b/drivers/net/ethernet/microchip/encx24j600_hw.h
@@ -243,7 +243,7 @@ int devm_regmap_init_encx24j600(struct device *dev,
/* MAIPG */
/* value of the high byte is given by the reserved bits,
- * value of the low byte is recomended setting of the
+ * value of the low byte is recommended setting of the
* IPG parameter.
*/
#define MAIPGH_VAL 0x0C
--
2.43.0
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH net-next 4/4] net: sparx5: Correct spelling in comments
2024-04-19 13:54 [PATCH net-next 0/4] net: microchip: Correct spelling in comments Simon Horman
` (2 preceding siblings ...)
2024-04-19 13:54 ` [PATCH net-next 3/4] net: encx24j600: " Simon Horman
@ 2024-04-19 13:54 ` Simon Horman
2024-04-20 19:24 ` Daniel Machon
3 siblings, 1 reply; 12+ messages in thread
From: Simon Horman @ 2024-04-19 13:54 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
Cc: Bryan Whitehead, Richard Cochran, Horatiu Vultur, Lars Povlsen,
Steen Hegelund, Daniel Machon, UNGLinuxDriver, netdev,
linux-arm-kernel
Correct spelling in comments, as flagged by codespell.
Signed-off-by: Simon Horman <horms@kernel.org>
---
drivers/net/ethernet/microchip/sparx5/sparx5_fdma.c | 2 +-
drivers/net/ethernet/microchip/sparx5/sparx5_packet.c | 2 +-
drivers/net/ethernet/microchip/sparx5/sparx5_port.c | 2 +-
drivers/net/ethernet/microchip/sparx5/sparx5_switchdev.c | 2 +-
drivers/net/ethernet/microchip/vcap/vcap_ag_api.h | 2 +-
drivers/net/ethernet/microchip/vcap/vcap_api.c | 4 ++--
drivers/net/ethernet/microchip/vcap/vcap_api_client.h | 2 +-
drivers/net/ethernet/microchip/vcap/vcap_api_private.h | 2 +-
8 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_fdma.c b/drivers/net/ethernet/microchip/sparx5/sparx5_fdma.c
index 141897dfe388..1915998f6079 100644
--- a/drivers/net/ethernet/microchip/sparx5/sparx5_fdma.c
+++ b/drivers/net/ethernet/microchip/sparx5/sparx5_fdma.c
@@ -143,7 +143,7 @@ static void sparx5_fdma_rx_activate(struct sparx5 *sparx5, struct sparx5_rx *rx)
static void sparx5_fdma_rx_deactivate(struct sparx5 *sparx5, struct sparx5_rx *rx)
{
- /* Dectivate the RX channel */
+ /* Deactivate the RX channel */
spx5_rmw(0, BIT(rx->channel_id) & FDMA_CH_ACTIVATE_CH_ACTIVATE,
sparx5, FDMA_CH_ACTIVATE);
diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_packet.c b/drivers/net/ethernet/microchip/sparx5/sparx5_packet.c
index ac7e1cffbcec..f3f5fb420468 100644
--- a/drivers/net/ethernet/microchip/sparx5/sparx5_packet.c
+++ b/drivers/net/ethernet/microchip/sparx5/sparx5_packet.c
@@ -67,7 +67,7 @@ static void sparx5_xtr_grp(struct sparx5 *sparx5, u8 grp, bool byte_swap)
for (i = 0; i < IFH_LEN; i++)
ifh[i] = spx5_rd(sparx5, QS_XTR_RD(grp));
- /* Decode IFH (whats needed) */
+ /* Decode IFH (what's needed) */
sparx5_ifh_parse(ifh, &fi);
/* Map to port netdev */
diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_port.c b/drivers/net/ethernet/microchip/sparx5/sparx5_port.c
index 60dd2fd603a8..062e486c002c 100644
--- a/drivers/net/ethernet/microchip/sparx5/sparx5_port.c
+++ b/drivers/net/ethernet/microchip/sparx5/sparx5_port.c
@@ -370,7 +370,7 @@ static int sparx5_port_disable(struct sparx5 *sparx5, struct sparx5_port *port,
/* 6: Wait while the last frame is exiting the queues */
usleep_range(8 * spd_prm, 10 * spd_prm);
- /* 7: Flush the queues accociated with the port->portno */
+ /* 7: Flush the queues associated with the port->portno */
spx5_rmw(HSCH_FLUSH_CTRL_FLUSH_PORT_SET(port->portno) |
HSCH_FLUSH_CTRL_FLUSH_DST_SET(1) |
HSCH_FLUSH_CTRL_FLUSH_SRC_SET(1) |
diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_switchdev.c b/drivers/net/ethernet/microchip/sparx5/sparx5_switchdev.c
index 4af85d108a06..0b4abc3eb53d 100644
--- a/drivers/net/ethernet/microchip/sparx5/sparx5_switchdev.c
+++ b/drivers/net/ethernet/microchip/sparx5/sparx5_switchdev.c
@@ -190,7 +190,7 @@ static int sparx5_port_bridge_join(struct sparx5_port *port,
/* Remove standalone port entry */
sparx5_mact_forget(sparx5, ndev->dev_addr, 0);
- /* Port enters in bridge mode therefor don't need to copy to CPU
+ /* Port enters in bridge mode therefore don't need to copy to CPU
* frames for multicast in case the bridge is not requesting them
*/
__dev_mc_unsync(ndev, sparx5_mc_unsync);
diff --git a/drivers/net/ethernet/microchip/vcap/vcap_ag_api.h b/drivers/net/ethernet/microchip/vcap/vcap_ag_api.h
index c3569a4c7b69..4735fad05708 100644
--- a/drivers/net/ethernet/microchip/vcap/vcap_ag_api.h
+++ b/drivers/net/ethernet/microchip/vcap/vcap_ag_api.h
@@ -290,7 +290,7 @@ enum vcap_keyfield_set {
* Sparx5: TCP flag RST , LAN966x: TCP: TCP flag RST. PTP over UDP: messageType
* bit 3
* VCAP_KF_L4_SEQUENCE_EQ0_IS: W1, sparx5: is2/es2, lan966x: is2
- * Set if TCP sequence number is 0, LAN966x: Overlayed with PTP over UDP:
+ * Set if TCP sequence number is 0, LAN966x: Overlaid with PTP over UDP:
* messageType bit 0
* VCAP_KF_L4_SPORT: W16, sparx5: is0/is2/es2, lan966x: is1/is2
* TCP/UDP source port
diff --git a/drivers/net/ethernet/microchip/vcap/vcap_api.c b/drivers/net/ethernet/microchip/vcap/vcap_api.c
index 80ae5e1708a6..a3b1dc7a5448 100644
--- a/drivers/net/ethernet/microchip/vcap/vcap_api.c
+++ b/drivers/net/ethernet/microchip/vcap/vcap_api.c
@@ -327,7 +327,7 @@ static int vcap_find_keystream_typegroup_sw(struct vcap_control *vctrl,
}
/* Verify that the typegroup information, subword count, keyset and type id
- * are in sync and correct, return the list of matchin keysets
+ * are in sync and correct, return the list of matching keysets
*/
int
vcap_find_keystream_keysets(struct vcap_control *vctrl,
@@ -2943,7 +2943,7 @@ void vcap_netbytes_copy(u8 *dst, u8 *src, int count)
}
EXPORT_SYMBOL_GPL(vcap_netbytes_copy);
-/* Convert validation error code into tc extact error message */
+/* Convert validation error code into tc exact error message */
void vcap_set_tc_exterr(struct flow_cls_offload *fco, struct vcap_rule *vrule)
{
switch (vrule->exterr) {
diff --git a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h
index 56874f2adbba..d6c3e90745a7 100644
--- a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h
+++ b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h
@@ -238,7 +238,7 @@ const struct vcap_set *vcap_keyfieldset(struct vcap_control *vctrl,
/* Copy to host byte order */
void vcap_netbytes_copy(u8 *dst, u8 *src, int count);
-/* Convert validation error code into tc extact error message */
+/* Convert validation error code into tc exact error message */
void vcap_set_tc_exterr(struct flow_cls_offload *fco, struct vcap_rule *vrule);
/* Cleanup a VCAP instance */
diff --git a/drivers/net/ethernet/microchip/vcap/vcap_api_private.h b/drivers/net/ethernet/microchip/vcap/vcap_api_private.h
index df81d9ff502b..844bdf6b5f45 100644
--- a/drivers/net/ethernet/microchip/vcap/vcap_api_private.h
+++ b/drivers/net/ethernet/microchip/vcap/vcap_api_private.h
@@ -109,7 +109,7 @@ int vcap_addr_keysets(struct vcap_control *vctrl, struct net_device *ndev,
struct vcap_keyset_list *kslist);
/* Verify that the typegroup information, subword count, keyset and type id
- * are in sync and correct, return the list of matchin keysets
+ * are in sync and correct, return the list of matching keysets
*/
int vcap_find_keystream_keysets(struct vcap_control *vctrl, enum vcap_type vt,
u32 *keystream, u32 *mskstream, bool mask,
--
2.43.0
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH net-next 4/4] net: sparx5: Correct spelling in comments
2024-04-19 13:54 ` [PATCH net-next 4/4] net: sparx5: " Simon Horman
@ 2024-04-20 19:24 ` Daniel Machon
2024-04-22 10:57 ` Simon Horman
0 siblings, 1 reply; 12+ messages in thread
From: Daniel Machon @ 2024-04-20 19:24 UTC (permalink / raw)
To: Simon Horman
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Bryan Whitehead, Richard Cochran, Horatiu Vultur, Lars Povlsen,
Steen Hegelund, UNGLinuxDriver, netdev, linux-arm-kernel
Hi Simon,
> -/* Convert validation error code into tc extact error message */
> +/* Convert validation error code into tc exact error message */
This seems wrong. I bet it refers to the 'netlink_ext_ack' struct. So
the fix should be 'extack' instead.
> void vcap_set_tc_exterr(struct flow_cls_offload *fco, struct vcap_rule *vrule)
> {
> switch (vrule->exterr) {
> diff --git a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h
> index 56874f2adbba..d6c3e90745a7 100644
> --- a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h
> +++ b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h
> @@ -238,7 +238,7 @@ const struct vcap_set *vcap_keyfieldset(struct vcap_control *vctrl,
> /* Copy to host byte order */
> void vcap_netbytes_copy(u8 *dst, u8 *src, int count);
>
> -/* Convert validation error code into tc extact error message */
> +/* Convert validation error code into tc exact error message */
Same here.
> void vcap_set_tc_exterr(struct flow_cls_offload *fco, struct vcap_rule *vrule);
The other fixes seems correct.
/Daniel
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH net-next 4/4] net: sparx5: Correct spelling in comments
2024-04-20 19:24 ` Daniel Machon
@ 2024-04-22 10:57 ` Simon Horman
2024-04-23 11:29 ` Daniel Machon
0 siblings, 1 reply; 12+ messages in thread
From: Simon Horman @ 2024-04-22 10:57 UTC (permalink / raw)
To: Daniel Machon
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Bryan Whitehead, Richard Cochran, Horatiu Vultur, Lars Povlsen,
Steen Hegelund, UNGLinuxDriver, netdev, linux-arm-kernel
On Sat, Apr 20, 2024 at 07:24:24PM +0000, Daniel Machon wrote:
> Hi Simon,
>
> > -/* Convert validation error code into tc extact error message */
> > +/* Convert validation error code into tc exact error message */
>
> This seems wrong. I bet it refers to the 'netlink_ext_ack' struct. So
> the fix should be 'extack' instead.
>
> > void vcap_set_tc_exterr(struct flow_cls_offload *fco, struct vcap_rule *vrule)
> > {
> > switch (vrule->exterr) {
> > diff --git a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h
> > index 56874f2adbba..d6c3e90745a7 100644
> > --- a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h
> > +++ b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h
> > @@ -238,7 +238,7 @@ const struct vcap_set *vcap_keyfieldset(struct vcap_control *vctrl,
> > /* Copy to host byte order */
> > void vcap_netbytes_copy(u8 *dst, u8 *src, int count);
> >
> > -/* Convert validation error code into tc extact error message */
> > +/* Convert validation error code into tc exact error message */
>
> Same here.
Thanks Daniel,
Silly me. I'll drop these changes in v2.
> > void vcap_set_tc_exterr(struct flow_cls_offload *fco, struct vcap_rule *vrule);
>
> The other fixes seems correct.
>
> /Daniel
>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH net-next 4/4] net: sparx5: Correct spelling in comments
2024-04-22 10:57 ` Simon Horman
@ 2024-04-23 11:29 ` Daniel Machon
2024-04-23 13:54 ` Simon Horman
0 siblings, 1 reply; 12+ messages in thread
From: Daniel Machon @ 2024-04-23 11:29 UTC (permalink / raw)
To: Simon Horman
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Bryan Whitehead, Richard Cochran, Horatiu Vultur, Lars Povlsen,
Steen Hegelund, UNGLinuxDriver, netdev, linux-arm-kernel
> > Hi Simon,
> >
> > > -/* Convert validation error code into tc extact error message */
> > > +/* Convert validation error code into tc exact error message */
> >
> > This seems wrong. I bet it refers to the 'netlink_ext_ack' struct. So
> > the fix should be 'extack' instead.
> >
> > > void vcap_set_tc_exterr(struct flow_cls_offload *fco, struct vcap_rule *vrule)
> > > {
> > > switch (vrule->exterr) {
> > > diff --git a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h
> > > index 56874f2adbba..d6c3e90745a7 100644
> > > --- a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h
> > > +++ b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h
> > > @@ -238,7 +238,7 @@ const struct vcap_set *vcap_keyfieldset(struct vcap_control *vctrl,
> > > /* Copy to host byte order */
> > > void vcap_netbytes_copy(u8 *dst, u8 *src, int count);
> > >
> > > -/* Convert validation error code into tc extact error message */
> > > +/* Convert validation error code into tc exact error message */
> >
> > Same here.
>
> Thanks Daniel,
>
> Silly me. I'll drop these changes in v2.
No reason to drop them just change it to 'extack' :-)
/Daniel
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH net-next 4/4] net: sparx5: Correct spelling in comments
2024-04-23 11:29 ` Daniel Machon
@ 2024-04-23 13:54 ` Simon Horman
2024-04-23 16:18 ` Simon Horman
0 siblings, 1 reply; 12+ messages in thread
From: Simon Horman @ 2024-04-23 13:54 UTC (permalink / raw)
To: Daniel Machon
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Bryan Whitehead, Richard Cochran, Horatiu Vultur, Lars Povlsen,
Steen Hegelund, UNGLinuxDriver, netdev, linux-arm-kernel
On Tue, Apr 23, 2024 at 11:29:15AM +0000, Daniel Machon wrote:
> > > Hi Simon,
> > >
> > > > -/* Convert validation error code into tc extact error message */
> > > > +/* Convert validation error code into tc exact error message */
> > >
> > > This seems wrong. I bet it refers to the 'netlink_ext_ack' struct. So
> > > the fix should be 'extack' instead.
> > >
> > > > void vcap_set_tc_exterr(struct flow_cls_offload *fco, struct vcap_rule *vrule)
> > > > {
> > > > switch (vrule->exterr) {
> > > > diff --git a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h
> > > > index 56874f2adbba..d6c3e90745a7 100644
> > > > --- a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h
> > > > +++ b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h
> > > > @@ -238,7 +238,7 @@ const struct vcap_set *vcap_keyfieldset(struct vcap_control *vctrl,
> > > > /* Copy to host byte order */
> > > > void vcap_netbytes_copy(u8 *dst, u8 *src, int count);
> > > >
> > > > -/* Convert validation error code into tc extact error message */
> > > > +/* Convert validation error code into tc exact error message */
> > >
> > > Same here.
> >
> > Thanks Daniel,
> >
> > Silly me. I'll drop these changes in v2.
>
> No reason to drop them just change it to 'extack' :-)
Thanks, will do.
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH net-next 4/4] net: sparx5: Correct spelling in comments
2024-04-23 13:54 ` Simon Horman
@ 2024-04-23 16:18 ` Simon Horman
2024-04-23 19:29 ` Daniel Machon
0 siblings, 1 reply; 12+ messages in thread
From: Simon Horman @ 2024-04-23 16:18 UTC (permalink / raw)
To: Daniel Machon
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Bryan Whitehead, Richard Cochran, Horatiu Vultur, Lars Povlsen,
Steen Hegelund, UNGLinuxDriver, netdev, linux-arm-kernel
On Tue, Apr 23, 2024 at 02:54:17PM +0100, Simon Horman wrote:
> On Tue, Apr 23, 2024 at 11:29:15AM +0000, Daniel Machon wrote:
> > > > Hi Simon,
> > > >
> > > > > -/* Convert validation error code into tc extact error message */
> > > > > +/* Convert validation error code into tc exact error message */
> > > >
> > > > This seems wrong. I bet it refers to the 'netlink_ext_ack' struct. So
> > > > the fix should be 'extack' instead.
> > > >
> > > > > void vcap_set_tc_exterr(struct flow_cls_offload *fco, struct vcap_rule *vrule)
> > > > > {
> > > > > switch (vrule->exterr) {
> > > > > diff --git a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h
> > > > > index 56874f2adbba..d6c3e90745a7 100644
> > > > > --- a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h
> > > > > +++ b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h
> > > > > @@ -238,7 +238,7 @@ const struct vcap_set *vcap_keyfieldset(struct vcap_control *vctrl,
> > > > > /* Copy to host byte order */
> > > > > void vcap_netbytes_copy(u8 *dst, u8 *src, int count);
> > > > >
> > > > > -/* Convert validation error code into tc extact error message */
> > > > > +/* Convert validation error code into tc exact error message */
> > > >
> > > > Same here.
> > >
> > > Thanks Daniel,
> > >
> > > Silly me. I'll drop these changes in v2.
> >
> > No reason to drop them just change it to 'extack' :-)
>
> Thanks, will do.
Sorry, I am somehow confused.
Do you mean like this?
/* Convert validation error code into extact error message */
Or just leave things unchanged?
/* Convert validation error code into tc extact error message */
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH net-next 4/4] net: sparx5: Correct spelling in comments
2024-04-23 16:18 ` Simon Horman
@ 2024-04-23 19:29 ` Daniel Machon
2024-04-24 14:59 ` Simon Horman
0 siblings, 1 reply; 12+ messages in thread
From: Daniel Machon @ 2024-04-23 19:29 UTC (permalink / raw)
To: Simon Horman
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Bryan Whitehead, Richard Cochran, Horatiu Vultur, Lars Povlsen,
Steen Hegelund, UNGLinuxDriver, netdev, linux-arm-kernel
> On Tue, Apr 23, 2024 at 02:54:17PM +0100, Simon Horman wrote:
> > On Tue, Apr 23, 2024 at 11:29:15AM +0000, Daniel Machon wrote:
> > > > > Hi Simon,
> > > > >
> > > > > > -/* Convert validation error code into tc extact error message */
> > > > > > +/* Convert validation error code into tc exact error message */
> > > > >
> > > > > This seems wrong. I bet it refers to the 'netlink_ext_ack' struct. So
> > > > > the fix should be 'extack' instead.
> > > > >
> > > > > > void vcap_set_tc_exterr(struct flow_cls_offload *fco, struct vcap_rule *vrule)
> > > > > > {
> > > > > > switch (vrule->exterr) {
> > > > > > diff --git a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h
> > > > > > index 56874f2adbba..d6c3e90745a7 100644
> > > > > > --- a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h
> > > > > > +++ b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h
> > > > > > @@ -238,7 +238,7 @@ const struct vcap_set *vcap_keyfieldset(struct vcap_control *vctrl,
> > > > > > /* Copy to host byte order */
> > > > > > void vcap_netbytes_copy(u8 *dst, u8 *src, int count);
> > > > > >
> > > > > > -/* Convert validation error code into tc extact error message */
> > > > > > +/* Convert validation error code into tc exact error message */
> > > > >
> > > > > Same here.
> > > >
> > > > Thanks Daniel,
> > > >
> > > > Silly me. I'll drop these changes in v2.
> > >
> > > No reason to drop them just change it to 'extack' :-)
> >
> > Thanks, will do.
>
> Sorry, I am somehow confused.
>
> Do you mean like this?
>
> /* Convert validation error code into extact error message */
>
> Or just leave things unchanged?
>
> /* Convert validation error code into tc extact error message */
Should be:
/* Convert validation error code into tc extack error message */
So the misspelling was real, just the fix was extack and not exact.
/Daniel
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH net-next 4/4] net: sparx5: Correct spelling in comments
2024-04-23 19:29 ` Daniel Machon
@ 2024-04-24 14:59 ` Simon Horman
0 siblings, 0 replies; 12+ messages in thread
From: Simon Horman @ 2024-04-24 14:59 UTC (permalink / raw)
To: Daniel Machon
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Bryan Whitehead, Richard Cochran, Horatiu Vultur, Lars Povlsen,
Steen Hegelund, UNGLinuxDriver, netdev, linux-arm-kernel
On Tue, Apr 23, 2024 at 07:29:30PM +0000, Daniel Machon wrote:
> > On Tue, Apr 23, 2024 at 02:54:17PM +0100, Simon Horman wrote:
> > > On Tue, Apr 23, 2024 at 11:29:15AM +0000, Daniel Machon wrote:
> > > > > > Hi Simon,
> > > > > >
> > > > > > > -/* Convert validation error code into tc extact error message */
> > > > > > > +/* Convert validation error code into tc exact error message */
> > > > > >
> > > > > > This seems wrong. I bet it refers to the 'netlink_ext_ack' struct. So
> > > > > > the fix should be 'extack' instead.
> > > > > >
> > > > > > > void vcap_set_tc_exterr(struct flow_cls_offload *fco, struct vcap_rule *vrule)
> > > > > > > {
> > > > > > > switch (vrule->exterr) {
> > > > > > > diff --git a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h
> > > > > > > index 56874f2adbba..d6c3e90745a7 100644
> > > > > > > --- a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h
> > > > > > > +++ b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h
> > > > > > > @@ -238,7 +238,7 @@ const struct vcap_set *vcap_keyfieldset(struct vcap_control *vctrl,
> > > > > > > /* Copy to host byte order */
> > > > > > > void vcap_netbytes_copy(u8 *dst, u8 *src, int count);
> > > > > > >
> > > > > > > -/* Convert validation error code into tc extact error message */
> > > > > > > +/* Convert validation error code into tc exact error message */
> > > > > >
> > > > > > Same here.
> > > > >
> > > > > Thanks Daniel,
> > > > >
> > > > > Silly me. I'll drop these changes in v2.
> > > >
> > > > No reason to drop them just change it to 'extack' :-)
> > >
> > > Thanks, will do.
> >
> > Sorry, I am somehow confused.
> >
> > Do you mean like this?
> >
> > /* Convert validation error code into extact error message */
> >
> > Or just leave things unchanged?
> >
> > /* Convert validation error code into tc extact error message */
>
> Should be:
>
> /* Convert validation error code into tc extack error message */
>
> So the misspelling was real, just the fix was extack and not exact.
Thanks, I see it now.
^ permalink raw reply [flat|nested] 12+ messages in thread