From: Simon Horman <horms@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com,
shironeko <shironeko@tesaguri.club>,
Jose Alonso <joalonsof@gmail.com>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH net] net: usb: ax88179_178a: stop lying about skb->truesize
Date: Tue, 23 Apr 2024 19:40:08 +0100 [thread overview]
Message-ID: <20240423184008.GZ42092@kernel.org> (raw)
In-Reply-To: <20240421193828.1966195-1-edumazet@google.com>
On Sun, Apr 21, 2024 at 07:38:28PM +0000, Eric Dumazet wrote:
> Some usb drivers try to set small skb->truesize and break
> core networking stacks.
>
> In this patch, I removed one of the skb->truesize overide.
>
> I also replaced one skb_clone() by an allocation of a fresh
> and small skb, to get minimally sized skbs, like we did
> in commit 1e2c61172342 ("net: cdc_ncm: reduce skb truesize
> in rx path")
>
> Fixes: f8ebb3ac881b ("net: usb: ax88179_178a: Fix packet receiving")
> Reported-by: shironeko <shironeko@tesaguri.club>
> Closes: https://lore.kernel.org/netdev/c110f41a0d2776b525930f213ca9715c@tesaguri.club/
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Jose Alonso <joalonsof@gmail.com>
> Cc: linux-usb@vger.kernel.org
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-04-23 18:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-21 19:38 [PATCH net] net: usb: ax88179_178a: stop lying about skb->truesize Eric Dumazet
2024-04-23 18:40 ` Simon Horman [this message]
2024-04-24 2:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240423184008.GZ42092@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=joalonsof@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shironeko@tesaguri.club \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).