From: Felix Fietkau <nbd@nbd.name>
To: netdev@vger.kernel.org
Cc: willemdebruijn.kernel@gmail.com, pabeni@redhat.com, edumazet@google.com
Subject: [PATCH net-next 0/4] Add TCP fraglist GRO support
Date: Wed, 24 Apr 2024 20:04:52 +0200 [thread overview]
Message-ID: <20240424180458.56211-1-nbd@nbd.name> (raw)
When forwarding TCP after GRO, software segmentation is very expensive,
especially when the checksum needs to be recalculated.
One case where that's currently unavoidable is when routing packets over
PPPoE. Performance improves significantly when using fraglist GRO
implemented in the same way as for UDP.
When NETIF_F_GRO_FRAGLIST is enabled, perform a lookup for an established
socket in the same netns as the receiving device. While this may not
cover all relevant use cases in multi-netns configurations, it should be
good enough for most configurations that need this.
Here's a measurement of running 2 TCP streams through a MediaTek MT7622
device (2-core Cortex-A53), which runs NAT with flow offload enabled from
one ethernet port to PPPoE on another ethernet port + cake qdisc set to
1Gbps.
rx-gro-list off: 630 Mbit/s, CPU 35% idle
rx-gro-list on: 770 Mbit/s, CPU 40% idle
Changes since RFC:
- split up patches
- handle TCP flags mutations
Felix Fietkau (4):
net: move skb_gro_receive_list from udp to core
net: add support for segmenting TCP fraglist GSO packets
net: add code for TCP fraglist GRO
net: add heuristic for enabling TCP fraglist GRO
include/net/gro.h | 1 +
include/net/tcp.h | 3 +-
net/core/gro.c | 27 ++++++++
net/ipv4/tcp_offload.c | 146 ++++++++++++++++++++++++++++++++++++++-
net/ipv4/udp_offload.c | 27 --------
net/ipv6/tcpv6_offload.c | 92 +++++++++++++++++++++++-
6 files changed, 265 insertions(+), 31 deletions(-)
--
2.44.0
next reply other threads:[~2024-04-24 18:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 18:04 Felix Fietkau [this message]
2024-04-24 18:04 ` [PATCH net-next 1/4] net: move skb_gro_receive_list from udp to core Felix Fietkau
2024-04-24 18:04 ` [PATCH net-next 2/4] net: add support for segmenting TCP fraglist GSO packets Felix Fietkau
2024-04-25 3:03 ` Willem de Bruijn
2024-04-25 7:51 ` Felix Fietkau
2024-04-26 8:00 ` Paolo Abeni
2024-04-24 18:04 ` [PATCH net-next 3/4] net: add code for TCP fraglist GRO Felix Fietkau
2024-04-26 8:14 ` Paolo Abeni
2024-04-24 18:04 ` [PATCH net-next 4/4] net: add heuristic for enabling " Felix Fietkau
2024-04-24 18:23 ` Eric Dumazet
2024-04-24 18:48 ` Felix Fietkau
2024-04-25 7:44 ` kernel test robot
2024-04-25 9:30 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240424180458.56211-1-nbd@nbd.name \
--to=nbd@nbd.name \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).