From: Jakub Kicinski <kuba@kernel.org>
To: Alexander Lobakin <aleksander.lobakin@intel.com>
Cc: Mateusz Polchlopek <mateusz.polchlopek@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>, <davem@davemloft.net>,
<pabeni@redhat.com>, <edumazet@google.com>,
<netdev@vger.kernel.org>, Jiri Pirko <jiri@nvidia.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>
Subject: Re: [PATCH net-next 1/6] devlink: extend devlink_param *set pointer
Date: Wed, 24 Apr 2024 20:08:58 -0700 [thread overview]
Message-ID: <20240424200858.1d0740a4@kernel.org> (raw)
In-Reply-To: <cdd3d9d7-1b21-4dc2-be21-ef137682b1ea@intel.com>
On Wed, 24 Apr 2024 11:05:58 +0200 Alexander Lobakin wrote:
> > int (*set)(struct devlink *devlink, u32 id,
> > - struct devlink_param_gset_ctx *ctx);
> > + struct devlink_param_gset_ctx *ctx,
> > + struct netlink_ext_ack *extack);
>
> Sorry for the late comment. Can't we embed extack to
> devlink_param_gset_ctx instead? It would take much less lines.
I think the way Mateusz wrote this is more prevalent today.
Also feels a tiny bit cleaner to me, because if we embed
extack why is devlink and id not embedded?
We've seen this series enough times, let me apply this as is..
Please follow up with the doc adjustments if you'd like, separately.
next prev parent reply other threads:[~2024-04-25 3:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 20:39 [PATCH net-next 0/6][pull request] ice: Support 5 layer Tx scheduler topology Tony Nguyen
2024-04-22 20:39 ` [PATCH net-next 1/6] devlink: extend devlink_param *set pointer Tony Nguyen
2024-04-24 9:05 ` Alexander Lobakin
2024-04-24 9:20 ` Przemek Kitszel
2024-04-24 9:24 ` Alexander Lobakin
2024-04-24 9:40 ` Przemek Kitszel
2024-04-24 9:52 ` Mateusz Polchlopek
2024-04-25 3:08 ` Jakub Kicinski [this message]
2024-04-22 20:39 ` [PATCH net-next 2/6] ice: Support 5 layer topology Tony Nguyen
2024-04-22 20:39 ` [PATCH net-next 3/6] ice: Adjust the VSI/Aggregator layers Tony Nguyen
2024-04-22 20:39 ` [PATCH net-next 4/6] ice: Enable switching default Tx scheduler topology Tony Nguyen
2024-04-22 20:39 ` [PATCH net-next 5/6] ice: Add tx_scheduling_layers devlink param Tony Nguyen
2024-04-22 20:39 ` [PATCH net-next 6/6] ice: Document tx_scheduling_layers parameter Tony Nguyen
2024-04-23 12:37 ` Bagas Sanjaya
2024-04-24 9:54 ` Mateusz Polchlopek
2024-04-24 10:47 ` Bagas Sanjaya
2024-04-25 3:10 ` [PATCH net-next 0/6][pull request] ice: Support 5 layer Tx scheduler topology patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240424200858.1d0740a4@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@nvidia.com \
--cc=mateusz.polchlopek@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).