[PATCH net-next v3 0/3] net: pse-pd: Fixes for few small issues

[PATCH net-next v3 0/3] net: pse-pd: Fixes for few small issues

[Kory Maincent]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1124 bytes --]

From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>

This patch series fix few issues in PSE net subsystem like Regulator
dependency, PSE regulator type and kernel Documentation.

Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---
Changes in v3:
- Add a missing Fixes tag.
- Remove "Dent project" from the patch author description.
- Link to v2: https://lore.kernel.org/r/20240422-fix_poe-v2-0-e58325950f07@bootlin.com

Changes in v2:
- Remove "Dent project" from my sob.
- Link to v1: https://lore.kernel.org/r/20240422-fix_poe-v1-0-811c8c0b9da7@bootlin.com

---
Kory Maincent (3):
      net: pse-pd: pse_core: Add missing kdoc return description
      net: pse-pd: pse_core: Fix pse regulator type
      net: pse-pd: Kconfig: Add missing Regulator API dependency

 drivers/net/pse-pd/Kconfig    |  2 +-
 drivers/net/pse-pd/pse_core.c | 10 +++++++++-
 2 files changed, 10 insertions(+), 2 deletions(-)
---
base-commit: 6a57f091622a1251c2826f7380577049199b80ea
change-id: 20240422-fix_poe-d0fb292c9d8e

Best regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

[PATCH net-next v3 1/3] net: pse-pd: pse_core: Add missing kdoc return description

[Kory Maincent]

From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>

Add missing kernel documentation return description.
This allows to remove all warning from kernel-doc test script.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Acked-by: Oleksij Rempel <o.rempel@pengutronix.de>
Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---
 drivers/net/pse-pd/pse_core.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/net/pse-pd/pse_core.c b/drivers/net/pse-pd/pse_core.c
index 31f23c454678..bad29eaa4d01 100644
--- a/drivers/net/pse-pd/pse_core.c
+++ b/drivers/net/pse-pd/pse_core.c
@@ -320,6 +320,8 @@ devm_pse_pi_regulator_register(struct pse_controller_dev *pcdev,
 /**
  * pse_controller_register - register a PSE controller device
  * @pcdev: a pointer to the initialized PSE controller device
+ *
+ * Return: 0 on success and failure value on error
  */
 int pse_controller_register(struct pse_controller_dev *pcdev)
 {
@@ -401,6 +403,8 @@ static void devm_pse_controller_release(struct device *dev, void *res)
  * Managed pse_controller_register(). For PSE controllers registered by
  * this function, pse_controller_unregister() is automatically called on
  * driver detach. See pse_controller_register() for more information.
+ *
+ * Return: 0 on success and failure value on error
  */
 int devm_pse_controller_register(struct device *dev,
 				 struct pse_controller_dev *pcdev)
@@ -627,6 +631,8 @@ EXPORT_SYMBOL_GPL(of_pse_control_get);
  * @psec: PSE control pointer
  * @extack: extack for reporting useful error messages
  * @status: struct to store PSE status
+ *
+ * Return: 0 on success and failure value on error
  */
 int pse_ethtool_get_status(struct pse_control *psec,
 			   struct netlink_ext_ack *extack,
@@ -704,6 +710,8 @@ static int pse_ethtool_podl_set_config(struct pse_control *psec,
  * @psec: PSE control pointer
  * @extack: extack for reporting useful error messages
  * @config: Configuration of the test to run
+ *
+ * Return: 0 on success and failure value on error
  */
 int pse_ethtool_set_config(struct pse_control *psec,
 			   struct netlink_ext_ack *extack,

-- 
2.34.1

Re: [PATCH net-next v3 1/3] net: pse-pd: pse_core: Add missing kdoc return description

[patchwork-bot+netdevbpf]

Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 23 Apr 2024 11:21:10 +0200 you wrote:
> From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>
> 
> Add missing kernel documentation return description.
> This allows to remove all warning from kernel-doc test script.
> 
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Acked-by: Oleksij Rempel <o.rempel@pengutronix.de>
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> 
> [...]

Here is the summary with links:
  - [net-next,v3,1/3] net: pse-pd: pse_core: Add missing kdoc return description
    https://git.kernel.org/netdev/net-next/c/fb1676ed7114
  - [net-next,v3,2/3] net: pse-pd: pse_core: Fix pse regulator type
    https://git.kernel.org/netdev/net-next/c/326f442784c2
  - [net-next,v3,3/3] net: pse-pd: Kconfig: Add missing Regulator API dependency
    https://git.kernel.org/netdev/net-next/c/2fa809b90617

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

[PATCH net-next v3 2/3] net: pse-pd: pse_core: Fix pse regulator type

[Kory Maincent]

From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>

Clarify PSE regulator as voltage regulator, not current.
The PSE (Power Sourcing Equipment) regulator is defined as a voltage
regulator, maintaining fixed voltage while accommodating varying current.

Fixes: d83e13761d5b ("net: pse-pd: Use regulator framework within PSE framework")
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Acked-by: Oleksij Rempel <o.rempel@pengutronix.de>
Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---
Change in v3:
- Add a missing Fixes tag.
---
 drivers/net/pse-pd/pse_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/pse-pd/pse_core.c b/drivers/net/pse-pd/pse_core.c
index bad29eaa4d01..795ab264eaf2 100644
--- a/drivers/net/pse-pd/pse_core.c
+++ b/drivers/net/pse-pd/pse_core.c
@@ -294,7 +294,7 @@ devm_pse_pi_regulator_register(struct pse_controller_dev *pcdev,
 	 */
 	rdesc->id = id;
 	rdesc->name = name;
-	rdesc->type = REGULATOR_CURRENT;
+	rdesc->type = REGULATOR_VOLTAGE;
 	rdesc->ops = &pse_pi_ops;
 	rdesc->owner = pcdev->owner;
 

-- 
2.34.1

[PATCH net-next v3 3/3] net: pse-pd: Kconfig: Add missing Regulator API dependency

[Kory Maincent]

From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>

The PSE (Power Sourcing Equipment) API now relies on the Regulator API.
However, the Regulator dependency was missing from Kconfig. This patch
adds the necessary dependency, resolving the issue of the missing
dependency and ensuring proper functionality of the PSE API.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202404201020.mqX2IOu7-lkp@intel.com/
Closes: https://lore.kernel.org/oe-kbuild-all/202404200036.D8ap1Mf5-lkp@intel.com/
Fixes: d83e13761d5b ("net: pse-pd: Use regulator framework within PSE framework")
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Acked-by: Oleksij Rempel <o.rempel@pengutronix.de>
Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---
 drivers/net/pse-pd/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/pse-pd/Kconfig b/drivers/net/pse-pd/Kconfig
index 80cf373a5a0e..577ea904b3d9 100644
--- a/drivers/net/pse-pd/Kconfig
+++ b/drivers/net/pse-pd/Kconfig
@@ -5,6 +5,7 @@
 
 menuconfig PSE_CONTROLLER
 	bool "Ethernet Power Sourcing Equipment Support"
+	depends on REGULATOR
 	help
 	  Generic Power Sourcing Equipment Controller support.
 
@@ -14,7 +15,6 @@ if PSE_CONTROLLER
 
 config PSE_REGULATOR
 	tristate "Regulator based PSE controller"
-	depends on REGULATOR || COMPILE_TEST
 	help
 	  This module provides support for simple regulator based Ethernet Power
 	  Sourcing Equipment without automatic classification support. For

-- 
2.34.1

Re: [PATCH net-next v3 0/3] net: pse-pd: Fixes for few small issues

[Jiri Pirko]

Tue, Apr 23, 2024 at 11:21:09AM CEST, kory.maincent@bootlin.com wrote:
>From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>
>
>This patch series fix few issues in PSE net subsystem like Regulator
>dependency, PSE regulator type and kernel Documentation.
>
>Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>

set-
Reviewed-by: Jiri Pirko <jiri@nvidia.com>

Re: [PATCH net-next v3 0/3] net: pse-pd: Fixes for few small issues

[Kory Maincent]

On Tue, 23 Apr 2024 13:28:00 +0200
Jiri Pirko <jiri@resnulli.us> wrote:

> Tue, Apr 23, 2024 at 11:21:09AM CEST, kory.maincent@bootlin.com wrote:
> >From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>
> >
> >This patch series fix few issues in PSE net subsystem like Regulator
> >dependency, PSE regulator type and kernel Documentation.
> >
> >Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>  
> 
> set-
> Reviewed-by: Jiri Pirko <jiri@nvidia.com>

Your reviewed-by tag has not been taken in the commit merged.
It seems patchwork does not take the cover letter tag reply into
account, I think only b4 does.

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

Re: [PATCH net-next v3 0/3] net: pse-pd: Fixes for few small issues

[Jakub Kicinski]

On Thu, 25 Apr 2024 10:31:10 +0200 Kory Maincent wrote:
> Your reviewed-by tag has not been taken in the commit merged.
> It seems patchwork does not take the cover letter tag reply into
> account, I think only b4 does.

Sorry about that.
The problem is that patchwork doesn't correctly group the cover letter
in your postings. Not sure why. 

Could you experiment with tweaking the posting?
Maybe we can "bisect" the problem.

Re: [PATCH net-next v3 0/3] net: pse-pd: Fixes for few small issues

[Kory Maincent]

On Thu, 25 Apr 2024 07:06:19 -0700
Jakub Kicinski <kuba@kernel.org> wrote:

> On Thu, 25 Apr 2024 10:31:10 +0200 Kory Maincent wrote:
> > Your reviewed-by tag has not been taken in the commit merged.
> > It seems patchwork does not take the cover letter tag reply into
> > account, I think only b4 does.  
> 
> Sorry about that.
> The problem is that patchwork doesn't correctly group the cover letter
> in your postings. Not sure why. 

Weird, I used b4 so it should work.

> Could you experiment with tweaking the posting?
> Maybe we can "bisect" the problem.

Do you want me to like post a v5 with the "pw-bot: cr" tag? But if I put the
tag only on the cover letter it won't work then. Maybe on all patches?
Was it the same for the PoE support patch series?
If so, we could look at it with my future patch series that will bring new
features to PoE.

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

Re: [PATCH net-next v3 0/3] net: pse-pd: Fixes for few small issues

[Jakub Kicinski]

On Thu, 25 Apr 2024 16:30:02 +0200 Kory Maincent wrote:
> > Could you experiment with tweaking the posting?
> > Maybe we can "bisect" the problem.  
> 
> Do you want me to like post a v5 with the "pw-bot: cr" tag? But if I put the
> tag only on the cover letter it won't work then.
> Maybe on all patches?

Probably not worth posting for a test. I'll try to be more careful when
applying in the future, we can experiment with real postings.

> Was it the same for the PoE support patch series?

Yeah, I had to apply that one manually.

> If so, we could look at it with my future patch series that will bring new
> features to PoE.

👍️

Re: [PATCH net-next v3 0/3] net: pse-pd: Fixes for few small issues

[Kory Maincent]

On Thu, 25 Apr 2024 07:42:05 -0700
Jakub Kicinski <kuba@kernel.org> wrote:

> On Thu, 25 Apr 2024 16:30:02 +0200 Kory Maincent wrote:
> > > Could you experiment with tweaking the posting?
> > > Maybe we can "bisect" the problem.    
> > 
> > Do you want me to like post a v5 with the "pw-bot: cr" tag? But if I put the
> > tag only on the cover letter it won't work then.
> > Maybe on all patches?  
> 
> Probably not worth posting for a test. I'll try to be more careful when
> applying in the future, we can experiment with real postings.
> 
> > Was it the same for the PoE support patch series?  
> 
> Yeah, I had to apply that one manually.

Mmh that's annoying.
Thanks for the information.

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

Re: [PATCH net-next v3 0/3] net: pse-pd: Fixes for few small issues

[Kory Maincent]

On Thu, 25 Apr 2024 07:42:05 -0700
Jakub Kicinski <kuba@kernel.org> wrote:

> On Thu, 25 Apr 2024 16:30:02 +0200 Kory Maincent wrote:
> > > Could you experiment with tweaking the posting?
> > > Maybe we can "bisect" the problem.    
> > 
> > Do you want me to like post a v5 with the "pw-bot: cr" tag? But if I put the
> > tag only on the cover letter it won't work then.
> > Maybe on all patches?  
> 
> Probably not worth posting for a test. I'll try to be more careful when
> applying in the future, we can experiment with real postings.
> 
> > Was it the same for the PoE support patch series?  
> 
> Yeah, I had to apply that one manually.

Does this patch series is on the same state?
https://lore.kernel.org/netdev/20240422-feature_ptp_netnext-v11-0-f14441f2a1d8@bootlin.com/

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

Re: [PATCH net-next v3 0/3] net: pse-pd: Fixes for few small issues

[Jakub Kicinski]

On Thu, 25 Apr 2024 16:57:08 +0200 Kory Maincent wrote:
> On Thu, 25 Apr 2024 07:42:05 -0700
> > > Do you want me to like post a v5 with the "pw-bot: cr" tag? But if I put the
> > > tag only on the cover letter it won't work then.
> > > Maybe on all patches?    
> > 
> > Probably not worth posting for a test. I'll try to be more careful when
> > applying in the future, we can experiment with real postings.
> >   
> > > Was it the same for the PoE support patch series?    
> > 
> > Yeah, I had to apply that one manually.  
> 
> Does this patch series is on the same state?
> https://lore.kernel.org/netdev/20240422-feature_ptp_netnext-v11-0-f14441f2a1d8@bootlin.com/

That one was fine:

https://patchwork.kernel.org/project/netdevbpf/cover/20240422-feature_ptp_netnext-v11-0-f14441f2a1d8@bootlin.com/

Are you thinking it's the extra From in the cover letter?

Re: [PATCH net-next v3 0/3] net: pse-pd: Fixes for few small issues

[Kory Maincent]

On Thu, 25 Apr 2024 08:07:24 -0700
Jakub Kicinski <kuba@kernel.org> wrote:

> On Thu, 25 Apr 2024 16:57:08 +0200 Kory Maincent wrote:
> > On Thu, 25 Apr 2024 07:42:05 -0700  
> > > > Do you want me to like post a v5 with the "pw-bot: cr" tag? But if I
> > > > put the tag only on the cover letter it won't work then.
> > > > Maybe on all patches?      
> > > 
> > > Probably not worth posting for a test. I'll try to be more careful when
> > > applying in the future, we can experiment with real postings.
> > >     
> > > > Was it the same for the PoE support patch series?      
> > > 
> > > Yeah, I had to apply that one manually.    
> > 
> > Does this patch series is on the same state?
> > https://lore.kernel.org/netdev/20240422-feature_ptp_netnext-v11-0-f14441f2a1d8@bootlin.com/
> >  
> 
> That one was fine:
> 
> https://patchwork.kernel.org/project/netdevbpf/cover/20240422-feature_ptp_netnext-v11-0-f14441f2a1d8@bootlin.com/
> 
> Are you thinking it's the extra From in the cover letter?

Maybe or some patches between b4 version 0.13.0 and 0.14-dev. I will try
next time without my extra From b4 patch to test 0.14-dev.

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

Re: [PATCH net-next v3 0/3] net: pse-pd: Fixes for few small issues

[Jakub Kicinski]

On Thu, 25 Apr 2024 19:04:26 +0200 Kory Maincent wrote:
> > That one was fine:
> > 
> > https://patchwork.kernel.org/project/netdevbpf/cover/20240422-feature_ptp_netnext-v11-0-f14441f2a1d8@bootlin.com/
> > 
> > Are you thinking it's the extra From in the cover letter?  
> 
> Maybe or some patches between b4 version 0.13.0 and 0.14-dev. I will try
> next time without my extra From b4 patch to test 0.14-dev.

Another random thought is that some people put the name in quotes if
it contains non-trivial chars, so may be worth trying with:

From: "Kory Maincent (Dent Project)" <kory.maincent@bootlin.com>

Re: [PATCH net-next v3 0/3] net: pse-pd: Fixes for few small issues

[Kory Maincent]

On Thu, 25 Apr 2024 10:15:11 -0700
Jakub Kicinski <kuba@kernel.org> wrote:

> On Thu, 25 Apr 2024 19:04:26 +0200 Kory Maincent wrote:
> > > That one was fine:
> > > 
> > > https://patchwork.kernel.org/project/netdevbpf/cover/20240422-feature_ptp_netnext-v11-0-f14441f2a1d8@bootlin.com/
> > > 
> > > Are you thinking it's the extra From in the cover letter?    
> > 
> > Maybe or some patches between b4 version 0.13.0 and 0.14-dev. I will try
> > next time without my extra From b4 patch to test 0.14-dev.  
> 
> Another random thought is that some people put the name in quotes if
> it contains non-trivial chars, so may be worth trying with:
> 
> From: "Kory Maincent (Dent Project)" <kory.maincent@bootlin.com>

Ok, I will try also with quotes.

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com